-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IF: Implement finalizer policy change at appropriate time #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
changed the title
Gh 1618
IF: Implement finalizer policy change at appropriate time
Apr 10, 2024
heifner
requested changes
Apr 11, 2024
Note:start |
…zer_policy changes.
heifner
reviewed
Apr 17, 2024
heifner
reviewed
Apr 17, 2024
More test cleanup will follow in a separate PR.
heifner
approved these changes
Apr 18, 2024
linh2931
reviewed
Apr 18, 2024
linh2931
approved these changes
Apr 18, 2024
heifner
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1618.
This initial implementation requires two 3-chains for a new
finalizer_policy
to become active.This updates the
finalizer_policies
flat_map to store astate
[proposed
,pending
] and afinalizer_policy
associated to a block_number:block_num => state, finalizer_policy
When
state == proposed
, theblock_num
identifies the block in which the new policy was proposed viaset_finalizers
.when that block becomes final, according to the
block_header_state
'sfinality_core
,pending
block_num
, in theproposer_policies
map, is the current blockWhen this current block itself becomes final, the policy becomes active.