[1.1.0 -> main] Do not allow replay-blockchain without snapshot #1158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow
--replay-blockchain
option without--snapshot
option unless a full block log is available as it will fail and leave the blockchain in a non-recoverable state.While attempting to reproduce #1152, I kicked off a
--replay-blockchain
but forgot to add the--snapshot
option. I didn't have a full block log. This resulted in the following:At this point the the state directory has to be removed and restart is required from the snapshot.
Merges
release/1.1
intomain
including #1156