Fix upacking() issues for std::optional, std::shared_ptr, std::set, and std::list #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed_ptr, std::set, and std::list
spoonincode
approved these changes
Jan 16, 2025
heifner
approved these changes
Jan 16, 2025
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of
unpacking()issues:std::optional: the target is not reset if the source does not have a value. This will causes mismatch of source and target if the target already has a value, as that value is kept.std::shared_ptr: the target is not reset if the source is null_ptr.std::set: the target is not set to empty if the source is empty, and the target is not clear if the source is not empty ending up with elements from both source and target.std::list: the target is not set to empty if the source is empty, and the target is not clear if the source is not empty ending up with elements from both source and target.The PR adds comprehensive tests for packing/unpacking
std::optional,std::shared_ptr,std::set, andstd::list.Resolves #1103