relax checktime_hashing_fail contract caching timing to eliminate spurious test failures
#1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Jan 15, 2025
linh2931
approved these changes
Jan 15, 2025
greg7mdp
approved these changes
Jan 15, 2025
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a fast Zen5 CPU, I see spurious failures on this line about 5% of the time (the action completes faster than 8ms resulting in the exception not firing). Reducing the limit to 6ms resolves the problem. But this is rather fragile and has been tweaked a number of times in the past. Since the purpose of this first action is to just get the contract cached, why not run a simple action that is guaranteed to pass to prime the cache?