Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable /v1/producer/pause_at_block #1057

Merged
merged 9 commits into from
Jan 22, 2025
Merged

Enable /v1/producer/pause_at_block #1057

merged 9 commits into from
Jan 22, 2025

Conversation

heifner
Copy link
Member

@heifner heifner commented Dec 6, 2024 •
edited
Loading

Enable new /v1/producer/pause_at_block endpoint for pausing a node at a particular block number. Use /v1/producer/resume to resume after pause.

See #1056 for most of the functionality of the implementation.

Resolves #570

@heifner heifner mentioned this pull request Dec 6, 2024
Merged
@heifner heifner added the OCI Work exclusive to OCI team label Dec 6, 2024
@heifner heifner marked this pull request as draft December 6, 2024 13:53
@heifner heifner requested review from greg7mdp and linh2931 December 6, 2024 13:54
greg7mdp
greg7mdp approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@greg7mdp greg7mdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test!

tests/pause_at_block_test.py Outdated Show resolved Hide resolved
tests/pause_at_block_test.py Show resolved Hide resolved
Base automatically changed from GH-570-pause-at-block to main December 9, 2024 13:58
@heifner heifner linked an issue Dec 12, 2024 that may be closed by this pull request
Add pause-at-block option #570
Closed
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: Plugins
summary: Test for producer_plugin pause_at_block
Note:end

@heifner heifner changed the title [2.0] Enable /v1/producer/pause_at_block Enable /v1/producer/pause_at_block Jan 17, 2025
@heifner heifner marked this pull request as ready for review January 17, 2025 14:03
@heifner heifner requested a review from spoonincode January 17, 2025 14:03
@heifner heifner merged commit 2b85452 into main Jan 22, 2025
36 checks passed
@heifner heifner deleted the GH-570-pause-at-block-test branch January 22, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@spoonincode spoonincode spoonincode approved these changes

@linh2931 linh2931 Awaiting requested review from linh2931

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pause-at-block option
4 participants
@heifner @ericpassmore @greg7mdp @spoonincode