Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to enter desired BSSID #4429

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

blazoncek
Copy link
Collaborator

@blazoncek blazoncek commented Dec 25, 2024

  • add event handling (for debug purposes and correct status setting)
  • fixes WiFi connection by BSSID #2151
  • moved WLED::initEthernet() and WLED::findWiFi() to network.cpp
  • added string conversion functions for MAC address (without colons)
  • used MAC conversion functions for configuration
  • replaced WLED_WIFI_CONFIGURED with function call (and updated macro)
  • fixed correct use of WLED_ETHERNET
  • added AP client counter (not really used currently but it will get its meaning soon if you stop bugging me with updating PR descriptions) 😉

Oh, and BTW, there is a bug in src/dependencies/network/Network.cpp.

- add event handling (debug)
- fixes Aircoookie#2151
@blazoncek blazoncek added enhancement connectivity Issue regarding protocols, WiFi connection or availability of interfaces labels Dec 25, 2024
Copy link

@Liliputech Liliputech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change overall with a nice move of initEthernet from wled.cpp to network.cpp.
Although most compilations (jobs) are successful, some of them have warnings (not breaking though)
Some of them seems to be related to your patch / code move.

@blazoncek
Copy link
Collaborator Author

That's just a harbinger of things to come. 😉

@netmindz
Copy link
Collaborator

Please update the PR title to fully summarise the changes contained and extend the description as well please @blazoncek

@blazoncek
Copy link
Collaborator Author

blazoncek commented Dec 26, 2024

@netmindz the gist of this PR is in its title - ability to force BSSID selection. All other changes are just collateral damage from my fork. I do not intend to remove those as it is too much hassle otherwise.

EDIT: The bugging part is a joke.

@dosipod
Copy link
Contributor

dosipod commented Dec 30, 2024

@blazoncek I do not have a mesh system but to test this I had to use two esp32 nat router with the same SSID .
And after a bit of testing we can select the BSSID needed and I can see from the router(s) side and also from json/info that wled was connected to that BSSID .

One minor issue during the setup ( this issue has no impact on functionality ) is that the BSSID is populated with the SSIDs and one will be selected for you , once you hit save you will get a bad BSSID as you see in the pic below but as you have to enter that manually in any case then this is a minor thing but for sure will be confusing to others .

image

@blazoncek
Copy link
Collaborator Author

Thank you.

@softhack007
Copy link
Collaborator

Oh, and BTW, there is a bug in src/dependencies/network/Network.cpp.

@blazoncek could you be a bit more specific? The file is not modified by your PR.

@blazoncek
Copy link
Collaborator Author

@softhack007 it is unrelated to this PR. Will include more info when ready.

@netmindz netmindz added this to the 0.16.0 candidate milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connectivity Issue regarding protocols, WiFi connection or availability of interfaces enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WiFi connection by BSSID
5 participants