Skip to content

Commit

Permalink
Add missing super() call in InferneceConfig.string_to_object
Browse files Browse the repository at this point in the history
  • Loading branch information
mdw771 committed May 22, 2024
1 parent 5669a09 commit d049b7b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion generic_trainer/configs.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ def string_to_object(self, key, value):
config = ModelParameters()
config.deserizalize_dict(value)
value = config
if key == 'parallelization_params' and isinstance(value, dict):
elif key == 'parallelization_params' and isinstance(value, dict):
config = ParallelizationConfig()
config.deserizalize_dict(value)
value = config
Expand Down Expand Up @@ -238,6 +238,7 @@ class InferenceConfig(Config):
"""

def string_to_object(self, key, value):
value = super().string_to_object(key, value)
if key == 'model_save_dir':
self.pretrained_model_path = os.path.join(value, 'best_model.pth')
return value
Expand Down

0 comments on commit d049b7b

Please sign in to comment.