Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 0.25 deg MOM6 parameter #73

Draft
wants to merge 1 commit into
base: dev-025deg_jra55do_ryf
Choose a base branch
from

Conversation

minghangli-uni
Copy link

This PR focuses on testing MOM6 parameters, specifically targeting the files MOM_input and MOM_parameter_doc.all.

The MOM_input file contains only the non-default parameters, while the MOM_parameter_doc.all is an auto-generated log that includes all used parameters.

As proposed in COSIMA/access-om3#117, MOM_parameter_doc.all along with MOM_parameter_doc.layout and MOM_parameter_doc.debugging provides comprehensive parameter documentation. To avoid confusion, MOM_parameter_doc.all will be updated along with MOM_input in this PR. Please note that there is an existing bug: MOM_parameter_doc.all does not include all used parameters.

The following MOM6 parameter updates will be implemented based on the existing ACCESS-OM2 0.25deg, a namelist discussion, GFDL OM4 0.25deg, and GFDL OM5 0.25deg.

For each commit, a block of parameters will be modified, accompanied by a detailed commit message explaining the reasons behind these changes. Additionally, an issue will be created to document and track each change.

@minghangli-uni
Copy link
Author

@aekiss , for the recent 0.4.0 build, some parameters that were previously set to true by default are now false, and vice versa. This has accidentally led to changes in the results COSIMA/access-om3#266. So i think a better approach would be to include MOM_parameter_doc.all in our configurations and set up a CI check for this file to ensure everything remains consistent. Any thoughts?

@anton-seaice
Copy link
Contributor

anton-seaice commented Feb 10, 2025

@aekiss has been suggesting that for a while - see COSIMA/access-om3#117

The recommendation from release team was to do this in payu / a userscript rather than CI

@anton-seaice
Copy link
Contributor

Oh - and I think in general we can adopt new defaults ... we just need to be aware / check them when we do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants