Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick 0.4.0 release related changes into 1deg_wombatlite #168

Merged
merged 16 commits into from
Feb 19, 2025
Merged

Cherry-pick 0.4.0 release related changes into 1deg_wombatlite #168

merged 16 commits into from
Feb 19, 2025

Conversation

anton-seaice
Copy link
Contributor

Cherry-pick changes from #161

The comparison between this branch and def-1deg_jra55do_ryf is useful to compare MOM_input:

https://github.com/ACCESS-NRI/access-om3-configs/compare/209-dev-1deg_jra55do_ryf_wombatlite..dev-1deg_jra55do_ryf

@anton-seaice
Copy link
Contributor Author

!test repro

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

✅ The Bitwise Reproducibility Check Succeeded ✅

When comparing:

  • 209-dev-1deg_jra55do_ryf_wombatlite (checksums created using commit 780539b), against
  • dev-1deg_jra55do_ryf_wombatlite (checksums in commit cc80e73)
Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/780539bd72a56562a6a61e0c70481e7ce5381479, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/36829030289.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13192870229/artifacts/2551894583.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/cc80e73f7699e810c746aee6689a2c54e8335313/testing/checksum

anton-seaice and others added 14 commits February 11, 2025 15:19
@anton-seaice @dougiesquire
License file
2d5aa44
@anton-seaice @minghangli-uni @dougiesquire
Update incorrect note in MOM_override
9e30cd5 
See COSIMA/access-om3#251

Co-authored-by: minghangli-uni <[email protected]>
@anton-seaice @dougiesquire
reorder MOM_input to follow MOM_parameter_doc.short
da43786 
Put non-default values from MOM_parameter_doc.debugging at the top

Co-authored-by: Dougie Squire <[email protected]>
@anton-seaice @dougiesquire
Add WIND_STAGGER to MOM_INPUT for clarity
1cbd3f2 
This only affects the logging, the actual value is hardcoded through a #ifdef CESMCOUPLED
@anton-seaice @dougiesquire
Remove unused components
a0ed288 
payu-org/payu#496 Removed some checks in Payu which required unused components to be present in the nuopc.runconfig file.

Co-authored-by: Dougie Squire <[email protected]>
@anton-seaice @dougiesquire
Update to ACCESS-NRI/ACCESS-OM3 deployment 25.01.0
6ea2f00
@anton-seaice @dougiesquire
Update field dictionary with latest from CMEPS
5510a93
@anton-seaice @dougiesquire
add_gusts parameter needed for 0.4.0 build
17444e4
@anton-seaice @dougiesquire
Update nuopc.runconfig to turn-off dates in restart_pointers
5da58f4
@anton-seaice @dougiesquire
Turn on netcdf4 per COSIMA/access-om3#81
c4acdd0 
The new build uses openmpi4.1.7, which fixes some bugs preventing parallel reads over symlinks. This allows use of parallelio netcdf4 option, even though at this resolution for most components we will still only use one PE for IO.
@anton-seaice @dougiesquire
Use .d and .m in CICE history output filenames
15695c8 
Per COSIMA/access-om3#201
@anton-seaice @dougiesquire
Turn off extra cice restarts and remove non functioning write_restart…
bb7945f 
…_at_endofrun

per COSIMA/access-om3#175
@anton-seaice @dougiesquire
Use mom supergrid as cice grid file
6b9f24a
@anton-seaice @dougiesquire
Set Earth radius the same as the UM
14ef9a9
@dougiesquire dougiesquire force-pushed the 209-dev-1deg_jra55do_ryf_wombatlite branch from 780539b to 14ef9a9 Compare February 11, 2025 04:19
@dougiesquire
Copy link
Collaborator

!test repro

@dougiesquire
Copy link
Collaborator

Note, I rebased everything onto the latest dev-1deg_jra55do_ryf_wombatlite so that the CI checks use the new reference checksums generated with the fixed model-config-tests

@github-actions GitHub Actions
Copy link

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

  • 209-dev-1deg_jra55do_ryf_wombatlite (checksums created using commit 14ef9a9), against
  • dev-1deg_jra55do_ryf_wombatlite (checksums in commit fa56d6c)
Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/14ef9a935efa3dd9c6d3098bce60fea926dec82c, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/37002550967.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13255817312/artifacts/2569210672.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/fa56d6ceaf88763cf1f0ce09fd3d53ca91b63a5d/testing/checksum

@dougiesquire dougiesquire mentioned this pull request Feb 17, 2025
Closed
@dougiesquire
Copy link
Collaborator

!test repro commit

dougiesquire
dougiesquire approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@dougiesquire dougiesquire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minghangli-uni, would be great to get your eyes on this also so I'm not approving my own changes

@github-actions GitHub Actions
Copy link

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

  • 209-dev-1deg_jra55do_ryf_wombatlite (checksums created using commit 0c5a1c1), against
  • dev-1deg_jra55do_ryf_wombatlite (checksums in commit fa56d6c)

🔧 The checksums will be committed to this PR, as they differ.

Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/0c5a1c1ebf24c89945020008e73949bcf3ad01c2, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/37376710588.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13383678858/artifacts/2606861779.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/fa56d6ceaf88763cf1f0ce09fd3d53ca91b63a5d/testing/checksum

minghangli-uni
minghangli-uni approved these changes Feb 18, 2025
View reviewed changes
Copy link

@minghangli-uni minghangli-uni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minghangli-uni
Copy link

!test repro

@github-actions GitHub Actions
Copy link

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

  • 209-dev-1deg_jra55do_ryf_wombatlite (checksums created using commit 0463909), against
  • dev-1deg_jra55do_ryf_wombatlite (checksums in commit fa56d6c)
Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/04639095b2fbf0538b26ca6f524420249b0e3a6f, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/37378129513.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13384210242/artifacts/2606991111.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/fa56d6ceaf88763cf1f0ce09fd3d53ca91b63a5d/testing/checksum

@minghangli-uni
Copy link

Same thing here, it is committing to ./test instead of ./test/checksum

@dougiesquire dougiesquire force-pushed the 209-dev-1deg_jra55do_ryf_wombatlite branch from 0463909 to 0c5a1c1 Compare February 18, 2025 23:34
@dougiesquire
Copy link
Collaborator

!test repro commit

@github-actions GitHub Actions
Copy link

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

  • 209-dev-1deg_jra55do_ryf_wombatlite (checksums created using commit 0c5a1c1), against
  • dev-1deg_jra55do_ryf_wombatlite (checksums in commit fa56d6c)

🔧 The checksums will be committed to this PR, as they differ.

Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/0c5a1c1ebf24c89945020008e73949bcf3ad01c2, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/37440495358.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13403971220/artifacts/2613444207.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/fa56d6ceaf88763cf1f0ce09fd3d53ca91b63a5d/testing/checksum

@dougiesquire dougiesquire merged commit 019f0dc into dev-1deg_jra55do_ryf_wombatlite Feb 19, 2025
10 checks passed
@dougiesquire dougiesquire deleted the 209-dev-1deg_jra55do_ryf_wombatlite branch February 19, 2025 02:53
This was referenced Feb 20, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minghangli-uni minghangli-uni minghangli-uni approved these changes

@dougiesquire dougiesquire dougiesquire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anton-seaice @dougiesquire @minghangli-uni @access-bot