Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick 0.4.0 release related changes into 1deg_iaf #167

Merged
merged 16 commits into from
Feb 19, 2025
Merged

Cherry-pick 0.4.0 release related changes into 1deg_iaf #167

merged 16 commits into from
Feb 19, 2025

Conversation

anton-seaice
Copy link
Contributor

Cherry-pick changes from #161

The comparison between this branch and def-1deg_jra55do_ryf is useful to compare MOM_input:

https://github.com/ACCESS-NRI/access-om3-configs/compare/209-dev-1deg_jra55do_iaf..dev-1deg_jra55do_ryf

@anton-seaice
Copy link
Contributor Author

!test repro

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

✅ The Bitwise Reproducibility Check Succeeded ✅

When comparing:

  • 209-dev-1deg_jra55do_iaf (checksums created using commit 581d4e8), against
  • dev-1deg_jra55do_iaf (checksums in commit 4259d19)
Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/581d4e894d516411fdd1b7dcee55d4102bc19ef9, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/36828430881.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13192625539/artifacts/2551830304.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/4259d19457011d74586789b5f6b65a9ff06f404c/testing/checksum

anton-seaice and others added 14 commits February 11, 2025 15:14
@anton-seaice @dougiesquire
License file
5a8e5bd
@anton-seaice @minghangli-uni @dougiesquire
Update incorrect note in MOM_override
1437598 
See COSIMA/access-om3#251

Co-authored-by: minghangli-uni <[email protected]>
@anton-seaice @dougiesquire
reorder MOM_input to follow MOM_parameter_doc, turn on FATAL_UNUSED_P…
621f59f 
…ARAMS
@anton-seaice @dougiesquire
Remove unused components
e0b23c2 
payu-org/payu#496 Removed some checks in Payu which required unused components to be present in the nuopc.runconfig file.

Co-authored-by: Dougie Squire <[email protected]>
@anton-seaice @dougiesquire
Update to ACCESS-NRI/ACCESS-OM3 deployment 25.01.0
624f552
@anton-seaice @dougiesquire
Update field dictionary with latest from CMEPS
657adb6
@anton-seaice @dougiesquire
add_gusts parameter needed for 0.4.0 build
5151e00
@anton-seaice @dougiesquire
Update nuopc.runconfig to turn-off dates in restart_pointers
b97a9dd
@anton-seaice @dougiesquire
Turn on netcdf4 per COSIMA/access-om3#81
412a542 
The new build uses openmpi4.1.7, which fixes some bugs preventing parallel reads over symlinks. This allows use of parallelio netcdf4 option, even though at this resolution for most components we will still only use one PE for IO.
@anton-seaice @dougiesquire
Use .d and .m in CICE history output filenames
e1a100b 
Per COSIMA/access-om3#201
@anton-seaice @dougiesquire
Turn off extra cice restarts and remove non functioning write_restart…
bcfefb2 
…_at_endofrun

per COSIMA/access-om3#175
@anton-seaice @dougiesquire
Use mom supergrid as cice grid file
1bc0c40
@anton-seaice @dougiesquire
Set Earth radius the same as the UM
3cc885b
@anton-seaice @dougiesquire
Add WIND_STAGGER to MOM_INPUT for clarity
240b86f 
This only affects the logging, the actual value is hardcoded through a #ifdef CESMCOUPLED
@dougiesquire dougiesquire force-pushed the 209-dev-1deg_jra55do_iaf branch from 581d4e8 to 240b86f Compare February 11, 2025 04:15
@dougiesquire
Copy link
Collaborator

!test repro

@dougiesquire
Copy link
Collaborator

dougiesquire commented Feb 11, 2025 •
edited
Loading

Note, I rebased everything onto the latest dev-1deg_jra55do_iaf so that the CI checks use the new reference checksums generated with the fixed model-config-tests

@github-actions GitHub Actions
Copy link

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

  • 209-dev-1deg_jra55do_iaf (checksums created using commit 240b86f), against
  • dev-1deg_jra55do_iaf (checksums in commit 3ded30a)
Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/240b86f4ea3fe59bcf73b4afd1909ffd42548b0d, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/37002455974.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13255759311/artifacts/2569200532.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/3ded30a1df427d8238695ca182705203d0b275c9/testing/checksum

@dougiesquire dougiesquire mentioned this pull request Feb 17, 2025
Closed
dougiesquire
dougiesquire approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@dougiesquire dougiesquire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minghangli-uni, would be great to get your eyes on this also so I'm not approving my own changes

@anton-seaice
Copy link
Contributor Author

I can't review my own PR but this needs update checksums committed. I think the pipeline is broken, don't merge just yet !

@anton-seaice
Copy link
Contributor Author

!test repro commit

@github-actions GitHub Actions
Copy link

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

  • 209-dev-1deg_jra55do_iaf (checksums created using commit 9ebbf2e), against
  • dev-1deg_jra55do_iaf (checksums in commit 3ded30a)

🔧 The checksums will be committed to this PR, as they differ.

Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/9ebbf2e305e530004258a93e764dd55ea179265f, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/37376162110.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13383483690/artifacts/2606806900.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/3ded30a1df427d8238695ca182705203d0b275c9/testing/checksum

@dougiesquire
Copy link
Collaborator

dougiesquire commented Feb 18, 2025 •
edited
Loading

@minghangli-uni , Tommy has now fixed the workflow and the new checksums have been committed. Are you happy with this PR?

@minghangli-uni minghangli-uni self-requested a review February 18, 2025 05:29
minghangli-uni
minghangli-uni approved these changes Feb 18, 2025
View reviewed changes
Copy link

@minghangli-uni minghangli-uni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But @dougiesquire you are @ a wrong person 😆

@minghangli-uni
Copy link

I think I should run a test repro before merging

@minghangli-uni
Copy link

!test repro

@github-actions GitHub Actions
Copy link

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

  • 209-dev-1deg_jra55do_iaf (checksums created using commit 07ff320), against
  • dev-1deg_jra55do_iaf (checksums in commit 3ded30a)
Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/07ff320ed20974b72362145c7717d17bc5d4eb68, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/37377365658.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13383931096/artifacts/2606921477.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/3ded30a1df427d8238695ca182705203d0b275c9/testing/checksum

@dougiesquire
Copy link
Collaborator

LGTM. But @dougiesquire you are @ a wrong person 😆

Sorry, not again!

@dougiesquire
Copy link
Collaborator

Hmmm, the workflow is committing the updated checksums to ./testing not ./testing/checksum. I've pinged Tommy about this

@dougiesquire dougiesquire force-pushed the 209-dev-1deg_jra55do_iaf branch from 07ff320 to 9ebbf2e Compare February 18, 2025 23:33
@aekiss
Copy link
Contributor

aekiss commented Feb 18, 2025

General comment. I noticed that there are large diffs in MOM_input, but this is partly (mostly?) non-semantic formatting changes. While these could be compared semantically with https://github.com/aekiss/nmltab, it would be better to standardise the format so the diffs are smaller (see COSIMA/access-om3#198). Is that what this PR is doing?

@dougiesquire
Copy link
Collaborator

dougiesquire commented Feb 18, 2025 •
edited
Loading

Is that what this PR is doing?

Yup

@anton-seaice
Copy link
Contributor Author

Yes this is implementing COSIMA/access-om3#200 - i.e reordering MOM_input to follow MOM_parameter_docs

It will make it easier to compare any differences and sync across configs later if desired (i.e. COSIMA/access-om3#198)

@dougiesquire
Copy link
Collaborator

!test repro commit

@github-actions GitHub Actions
Copy link

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

  • 209-dev-1deg_jra55do_iaf (checksums created using commit 9ebbf2e), against
  • dev-1deg_jra55do_iaf (checksums in commit 3ded30a)

🔧 The checksums will be committed to this PR, as they differ.

Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/9ebbf2e305e530004258a93e764dd55ea179265f, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/37440517127.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/13403967450/artifacts/2613446193.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/3ded30a1df427d8238695ca182705203d0b275c9/testing/checksum

@dougiesquire dougiesquire merged commit 23ca28d into dev-1deg_jra55do_iaf Feb 19, 2025
10 checks passed
@dougiesquire dougiesquire deleted the 209-dev-1deg_jra55do_iaf branch February 19, 2025 02:19
This was referenced Feb 20, 2025
Closed
Closed
Closed
Closed
Open
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minghangli-uni minghangli-uni minghangli-uni approved these changes

@dougiesquire dougiesquire dougiesquire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anton-seaice @dougiesquire @minghangli-uni @aekiss @access-bot