doc: add break word all for better ux #753
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rasvanjaya21 is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franky47
requested changes
Nov 9, 2024
| @@ -28,7 +28,7 @@ export function Demo() { | |||
| <> | |||
| <input value={name || ''} onChange={e => setName(e.target.value)} /> | |||
| <button onClick={() => setName(null)}>Clear</button> | |||
| <p>Hello, {name || 'anonymous visitor'}!</p> | |||
| <p className="break-all">Hello, {name || 'anonymous visitor'}!</p> | |||
There was a problem hiding this comment.
suggestion: styles are not needed in documentation code blocks, they distract from the main intent (showing how to use nuqs).
Suggested change
| <p className="break-all">Hello, {name || 'anonymous visitor'}!</p> | |
| <p>Hello, {name || 'anonymous visitor'}!</p> |
| @@ -24,7 +24,7 @@ export function Demo() { | |||
| onChange={e => setHello(e.target.value || null)} | |||
| data-interacted={Boolean(hello)} | |||
| /> | |||
| <p>Hello, {hello || 'anonymous visitor'}!</p> | |||
| <p className="break-all">Hello, {hello || 'anonymous visitor'}!</p> | |||
There was a problem hiding this comment.
suggestion: this file isn't used in the codebase, it was just a demo of how GitHub uses search params to store state, we should probably remove it.
Suggested change
| <p className="break-all">Hello, {hello || 'anonymous visitor'}!</p> | |
| <p>Hello, {hello || 'anonymous visitor'}!</p> |
| @@ -21,7 +21,7 @@ export async function LandingDemo() { | |||
| <div className="mb-4 h-[136px] animate-pulse rounded bg-zinc-50 dark:bg-zinc-900 sm:h-10" /> | |||
| } | |||
| > | |||
| <div className="mb-4 flex flex-col gap-4 sm:flex-row sm:items-center"> | |||
There was a problem hiding this comment.
Looks like this change broke the layout on mobile, the items should be full width:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented #752