Clean up provider.js

[josemigallas]

Part of THREESCALE-9982: Unify jquery across 3scale

[mayorova]

I've got two concerns:

1. I am not able to make the cucumber tests partials.feature and portlets.feature pass locally, despite running assets:clobber and assets:precompile multiple times. The behavior which causes a failure is that the button "New X" appears, but clicking on it doesn't open the dropdown.
2. In the development server the button does work, and opens the dropdown list, however clicking on the arrow again doesn't collapse it. Only clicking outside of the button collapses it. I think the dropdown should close also when clicking again on the arrow button.

[mayorova]

Some more info on these two concerns:

1. I am not able to make the cucumber tests partials.feature and portlets.feature pass locally, despite running assets:clobber and assets:precompile multiple times. The behavior which causes a failure is that the button "New X" appears, but clicking on it doesn't open the dropdown.

Troubleshooting this further shows that for some reason the action find('.dropdown-toggle').click doesn't result in the correct element being clicked. Instead of $(document).on('click', '.dropdown-toggle', the $(document).on('click', 'body' event is triggered. Also, the arrow button gets highlighted (as when hovered over). Adding a second find('.dropdown-toggle').click in the step does click properly and opens the dropdown, but this is incorrect. Apparently this only happens locally? Could it be a bug in the chromedriver? 🤔 Any ideas? This just drives me nuts.

2. In the development server the button does work, and opens the dropdown list, however clicking on the arrow again doesn't collapse it. Only clicking outside of the button collapses it. I think the dropdown should close also when clicking again on the arrow button.

I think this is because of calling closeAllDropdowns on clicking the toggle. So, it always first closes the expanded dropdown (in a bulk action), and then toggles the class again, hence always expanding it, and never collapsing. I've left some inline suggestions. Probably not to be applied directly, but you get the point - basically the closeAllDropdowns accepts an argument, and will close all dropdowns except the element passed to it.