Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting closer on Storybook and Superforms #1

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Getting closer on Storybook and Superforms #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aad2a98
WIP: Improved enhance function
ciscoheat Mar 4, 2024
305f375
WIP: Adding patch
ciscoheat Mar 4, 2024
a9ff886
Patched storybook:enhance event
ciscoheat Mar 4, 2024
033bf10
Added mock enhance function.
ciscoheat Mar 4, 2024
87b7ec5
Re-added Superforms package.
ciscoheat Mar 4, 2024
1ff90cc
Ready for Superforms 2.8.0
ciscoheat Mar 5, 2024
4d5462b
Package updates
ciscoheat Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 60 additions & 54 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,56 +1,62 @@
{
"name": "storybook-request-submit",
"version": "0.0.1",
"scripts": {
"dev": "vite dev",
"build": "vite build",
"preview": "vite preview",
"test": "npm run test:integration && npm run test:unit",
"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
"lint": "prettier --check . && eslint .",
"format": "prettier --write .",
"test:integration": "playwright test",
"test:unit": "vitest",
"storybook": "storybook dev -p 6006",
"build-storybook": "storybook build"
},
"devDependencies": {
"@fontsource/fira-mono": "^4.5.10",
"@neoconfetti/svelte": "^1.0.0",
"@playwright/test": "^1.28.1",
"@storybook/addon-essentials": "^7.6.17",
"@storybook/addon-interactions": "^7.6.17",
"@storybook/addon-links": "^7.6.17",
"@storybook/blocks": "^7.6.17",
"@storybook/svelte": "^7.6.17",
"@storybook/sveltekit": "^7.6.17",
"@storybook/test": "^7.6.17",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.0.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"@types/eslint": "^8.56.0",
"@typescript-eslint/eslint-plugin": "^7.0.0",
"@typescript-eslint/parser": "^7.0.0",
"eslint": "^8.56.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-storybook": "^0.8.0",
"eslint-plugin-svelte": "^2.35.1",
"prettier": "^3.1.1",
"prettier-plugin-svelte": "^3.1.2",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"storybook": "^7.6.17",
"svelte": "^4.2.7",
"svelte-check": "^3.6.0",
"tslib": "^2.4.1",
"typescript": "^5.0.0",
"vite": "^5.0.3",
"vitest": "^1.2.0"
},
"type": "module",
"dependencies": {
"sveltekit-superforms": "^2.6.2",
"zod": "^3.22.4"
}
"name": "storybook-request-submit",
"version": "0.0.1",
"scripts": {
"dev": "vite dev",
"build": "vite build",
"preview": "vite preview",
"test": "npm run test:integration && npm run test:unit",
"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
"lint": "prettier --check . && eslint .",
"format": "prettier --write .",
"test:integration": "playwright test",
"test:unit": "vitest",
"storybook": "storybook dev -p 6006",
"build-storybook": "storybook build"
},
"devDependencies": {
"@fontsource/fira-mono": "^4.5.10",
"@neoconfetti/svelte": "^1.0.0",
"@playwright/test": "^1.42.1",
"@storybook/addon-essentials": "^7.6.17",
"@storybook/addon-interactions": "^7.6.17",
"@storybook/addon-links": "^7.6.17",
"@storybook/blocks": "^7.6.17",
"@storybook/svelte": "^7.6.17",
"@storybook/sveltekit": "^7.6.17",
"@storybook/test": "^7.6.17",
"@sveltejs/adapter-auto": "^3.1.1",
"@sveltejs/kit": "^2.5.2",
"@sveltejs/vite-plugin-svelte": "^3.0.2",
"@types/eslint": "^8.56.5",
"@typescript-eslint/eslint-plugin": "^7.1.1",
"@typescript-eslint/parser": "^7.1.1",
"devalue": "^4.3.2",
"eslint": "^8.57.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-storybook": "^0.8.0",
"eslint-plugin-svelte": "^2.35.1",
"prettier": "^3.2.5",
"prettier-plugin-svelte": "^3.2.2",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"storybook": "^7.6.17",
"svelte": "^4.2.12",
"svelte-check": "^3.6.6",
"sveltekit-superforms": "^2.8.0",
"tslib": "^2.6.2",
"typescript": "^5.3.3",
"vite": "^5.1.5",
"vitest": "^1.3.1"
},
"type": "module",
"dependencies": {
"zod": "^3.22.4"
},
"pnpm": {
"patchedDependencies": {
"@storybook/[email protected]": "patches/@[email protected]"
}
}
}
86 changes: 86 additions & 0 deletions patches/@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
diff --git a/src/mocks/app/forms.ts b/src/mocks/app/forms.ts
index d1b26867c7d6580c5978c731c9e735a58b8a8a1a..8aa823882b0c5738f4d61b3f83a0be00acfe7686 100644
--- a/src/mocks/app/forms.ts
+++ b/src/mocks/app/forms.ts
@@ -1,17 +1,29 @@
-export function enhance(form: HTMLFormElement) {
- const listener = (e: Event) => {
- e.preventDefault();
- const event = new CustomEvent('storybook:enhance');
- window.dispatchEvent(event);
- };
- form.addEventListener('submit', listener);
- return {
- destroy() {
- form.removeEventListener('submit', listener);
- },
- };
+import type { SubmitFunction } from '@sveltejs/kit';
+
+export type EnhanceData = {
+ formElement: HTMLFormElement;
+ submitFunction: SubmitFunction;
+ submitEvent: SubmitEvent;
+};
+
+export function enhance(formElement: HTMLFormElement, submitFunction: SubmitFunction) {
+ const listener = (e: Event) => {
+ const event = new CustomEvent('storybook:enhance', {
+ detail: {
+ formElement,
+ submitFunction,
+ submitEvent: e
+ }
+ });
+ window.dispatchEvent(event);
+ };
+ formElement.addEventListener('submit', listener);
+ return {
+ destroy() {
+ formElement.removeEventListener('submit', listener);
+ }
+ };
}

export function applyAction() {}
-
export function deserialize() {}
diff --git a/template/stories_svelte-kit-skeleton-js/environment.stories.js b/template/stories_svelte-kit-skeleton-js/environment.stories.js
deleted file mode 100644
index a8baaabbf5be58764f8126e1f3a646eb533b9e91..0000000000000000000000000000000000000000
diff --git a/template/stories_svelte-kit-skeleton-js/forms.stories.js b/template/stories_svelte-kit-skeleton-js/forms.stories.js
deleted file mode 100644
index 72b584baef76e7e14578d01d877b53833a21da66..0000000000000000000000000000000000000000
diff --git a/template/stories_svelte-kit-skeleton-js/hrefs.stories.js b/template/stories_svelte-kit-skeleton-js/hrefs.stories.js
deleted file mode 100644
index f1cbf49735344e5c207149697cb413da63f0e3fc..0000000000000000000000000000000000000000
diff --git a/template/stories_svelte-kit-skeleton-js/navigation.stories.js b/template/stories_svelte-kit-skeleton-js/navigation.stories.js
deleted file mode 100644
index 8640d467c463ee803e5009fa3db492ef9e1c1728..0000000000000000000000000000000000000000
diff --git a/template/stories_svelte-kit-skeleton-js/paths.stories.js b/template/stories_svelte-kit-skeleton-js/paths.stories.js
deleted file mode 100644
index 5d87296483a585cc22ad925a923013db7ee752e3..0000000000000000000000000000000000000000
diff --git a/template/stories_svelte-kit-skeleton-js/stores.stories.js b/template/stories_svelte-kit-skeleton-js/stores.stories.js
deleted file mode 100644
index 7f7401cf8bee8dacfe18b8e6c41989f39ff6d41c..0000000000000000000000000000000000000000
diff --git a/template/stories_svelte-kit-skeleton-ts/environment.stories.js b/template/stories_svelte-kit-skeleton-ts/environment.stories.js
deleted file mode 100644
index a8baaabbf5be58764f8126e1f3a646eb533b9e91..0000000000000000000000000000000000000000
diff --git a/template/stories_svelte-kit-skeleton-ts/forms.stories.js b/template/stories_svelte-kit-skeleton-ts/forms.stories.js
deleted file mode 100644
index 72b584baef76e7e14578d01d877b53833a21da66..0000000000000000000000000000000000000000
diff --git a/template/stories_svelte-kit-skeleton-ts/hrefs.stories.js b/template/stories_svelte-kit-skeleton-ts/hrefs.stories.js
deleted file mode 100644
index f1cbf49735344e5c207149697cb413da63f0e3fc..0000000000000000000000000000000000000000
diff --git a/template/stories_svelte-kit-skeleton-ts/navigation.stories.js b/template/stories_svelte-kit-skeleton-ts/navigation.stories.js
deleted file mode 100644
index 8640d467c463ee803e5009fa3db492ef9e1c1728..0000000000000000000000000000000000000000
diff --git a/template/stories_svelte-kit-skeleton-ts/paths.stories.js b/template/stories_svelte-kit-skeleton-ts/paths.stories.js
deleted file mode 100644
index 5d87296483a585cc22ad925a923013db7ee752e3..0000000000000000000000000000000000000000
diff --git a/template/stories_svelte-kit-skeleton-ts/stores.stories.js b/template/stories_svelte-kit-skeleton-ts/stores.stories.js
deleted file mode 100644
index 7f7401cf8bee8dacfe18b8e6c41989f39ff6d41c..0000000000000000000000000000000000000000
diff --git a/template/stories_svelte-kit-skeleton-ts/ts-docs.stories.js b/template/stories_svelte-kit-skeleton-ts/ts-docs.stories.js
deleted file mode 100644
index f33428810ee9f480e6accbec8bac2ef44ee78327..0000000000000000000000000000000000000000
Loading