Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use normal import for XSS #870

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: use normal import for XSS #870

merged 2 commits into from
Nov 18, 2024

Conversation

Antonio-Laguna
Copy link
Member

Description of the Change

The current behaviour for importing XSS into wpKsesPost is not working fine within some environments. Especially this has been blowing up within Storybook

image

How to test the Change

Run tests and test within any of the examples. This should just keep working and sanitizing output.

Changelog Entry

Fixed - Import for XSS within wpKsesPost to ensure it works correctly across more strict environments.

Checklist:

@Antonio-Laguna Antonio-Laguna self-assigned this Nov 18, 2024
Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: 9d7ca72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@headstartwp/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headstartwp-app-router ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:55pm
headstarwp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:55pm

@Antonio-Laguna
Copy link
Member Author

@nicholasio I'm not sure about changeset, let me know about this. Ideally, we get this under the .next tag ASAP since this is blocking but let me know what's feasible

Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headstartwp

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 124.1 KB (🟢 -180 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headstartwp

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 124.1 KB (🟢 -180 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@nicholasio nicholasio merged commit 5290658 into develop Nov 18, 2024
17 of 18 checks passed
@nicholasio nicholasio deleted the fix/sanitize-import branch November 18, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants