Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Regression: "From" and "To" can not be expanded if an article is loaded after opening TIcketZoom #605

Open
olifre opened this issue Oct 18, 2024 · 1 comment
Labels
1 - 🐞 bug 🐞 An issue with the system. 4 - internal Issue/MR 4 - verified This issue or pull request was verified.

Comments

@olifre
Copy link

olifre commented Oct 18, 2024

Environment

  • Server OS: Linux
  • Browser: Tested with Firefox and Chromium
  • Znuny version: since 7.0.8

Expected behavior

Clicking on "From" and "To" in an article should expand the full mail address, i.e.:

John Doe

should be expanded to:

John Doe <[email protected]>

(and unexpanded again when clicking again).

Actual behavior

This works if a ticket is visited directly, i.e.:
https://someserver.example.com/znuny/index.pl?Action=AgentTicketZoom;TicketID=1234
but fails either if:

How to reproduce

Steps to reproduce the behavior:

  1. Visit any ticket which has some name and mail address in From / To.
  2. Click on "From" or "To".
  3. Observe it is expanded.
  4. Visit the ticket via an article URL or click on an article to load it.
  5. Observe it is not expandable anymore.

Additional information

This is a regression caused by:
4f3baef
which adapted the template to use div instead of p, but only adapted the javascript code in:

// add switchable toggle
$('label.Switchable').off('click.Switch').on('click.Switch', function() {
$(this).next('div').find('.Switch').toggleClass('Hidden');
});

(i.e. Init of Core.Agent.TicketZoom), but not in:
// add switchable toggle for new article
$('label.Switchable').off('click.Switch').on('click.Switch', function() {
$(this).next('p.Value').find('.Switch').toggleClass('Hidden');
});

(i.e. LoadArticle of Core.Agent.TicketZoom).

Adapting the second location should fix the problem 😉 .

@olifre olifre changed the title Bug - [short text describing the problem] Bug - Regression: "From" and "To" can not be expanded if an article is loaded after opening TIcketZoom Oct 18, 2024
@dignin dignin added 1 - 🐞 bug 🐞 An issue with the system. 4 - internal Issue/MR labels Nov 4, 2024
@dignin
Copy link

dignin commented Nov 4, 2024

Internal Issue# 991

@dignin dignin added the 4 - verified This issue or pull request was verified. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🐞 bug 🐞 An issue with the system. 4 - internal Issue/MR 4 - verified This issue or pull request was verified.
Development

No branches or pull requests

2 participants