Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BACKUP_DAYS_TO_RETAIN to the Backup Script #1066

Open
fengluodb opened this issue Dec 31, 2024 · 1 comment
Open

Add BACKUP_DAYS_TO_RETAIN to the Backup Script #1066

fengluodb opened this issue Dec 31, 2024 · 1 comment

Comments

@fengluodb
Copy link

fengluodb commented Dec 31, 2024

Currently in Spilo, BACKUP_NUM_TO_RETAIN is being used to represent the number of days to retain backups, which can be misleading. I recommend introducing BACKUP_DAYS_TO_RETAIN to clarify this purpose, while keeping BACKUP_NUM_TO_RETAIN specifically for limiting the total number of backups in the script.

ref:

DAYS_TO_RETAIN=$BACKUP_NUM_TO_RETAIN

@fengluodb
Copy link
Author

if you find this suggestion feasible, please assign the issue to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant