We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We currently have a "semi-controlled" component which I think is an anti-pattern.
We should make SplitPane "controlled", meaning the size which is passed is always the actual size (same for "closed").
The effect which syncs the external configuration's size of the panel and the local state should reside outside of this component.
@hamed-musallam
The text was updated successfully, but these errors were encountered:
The semi-controlled pattern I refer to is the one implemented in #457
Sorry, something went wrong.
I think most of the time, not all end users need to control the size and closed properties but I agree that maybe it is better to lift the state up.
size
closed
No branches or pull requests
We currently have a "semi-controlled" component which I think is an anti-pattern.
We should make SplitPane "controlled", meaning the size which is passed is always the actual size (same for "closed").
The effect which syncs the external configuration's size of the panel and the local state should reside outside of this component.
@hamed-musallam
The text was updated successfully, but these errors were encountered: