Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TypedArray support on write #558

Open
legendecas opened this issue Sep 10, 2019 · 3 comments
Open

net: TypedArray support on write #558

legendecas opened this issue Sep 10, 2019 · 3 comments

Comments

@legendecas
Copy link
Contributor

  • Version: v0.11.x
  • Platform: all
  • Subsystem: net

Socket#write doesn't accept TypedArray.

var conn = net.createConnection('foo.sock')
conn.write(new UInt8Array(2)) // TypeError: invalid argument
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.70. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@yorkie yorkie added the good first issue Issues that are suitable for first-time contributors. label Sep 11, 2019
@Txiaozhe
Copy link
Contributor

UInt8Array -> Uint8Array

@yorkie yorkie removed the good first issue Issues that are suitable for first-time contributors. label Sep 21, 2019
@yorkie
Copy link
Member

yorkie commented Sep 21, 2019

Removed the label "good first issue" it might be as some jobs that do:

  • fix document and source code are inconsistent,
  • improve the documents,
  • improve the source code by env, include and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants