Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Set Featured Image" button #57

Open
kean opened this issue Jan 9, 2025 · 0 comments
Open

Add "Set Featured Image" button #57

kean opened this issue Jan 9, 2025 · 0 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@kean
Copy link
Contributor

kean commented Jan 9, 2025

What problem does this address?

The full version of the editor has the "Set Featured Image" button in the "More" menu for image blocks. The mobile version also needs one.

Technical Notes

The primary way to manage featured images is via the native "Post Settings" screen, as featured images are part of the post metadata and not the post content. Gutenberg Mobile solves it using the following callback:

func gutenbergDidRequestToSetFeaturedImage(for mediaID: Int32)

In the current implementation, the updates are two-directional: the app also communicates the changes to the featured image back to the editor using FeaturedImageDelegate (iOS). It only exists to support the "Featured" badge and the "Remove Featured Image" buttons in the editor. I suggest removing this part because it's error-prone and requires too much effort for too little value. The full web editor also doesn't support it as they seemingly made the same calculation.

@kean kean added the [Type] Enhancement A suggestion for improvement. label Jan 9, 2025
@dcalhoun dcalhoun added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take and removed [Type] Task Issues or PRs that have been broken down into an individual action to take Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants