Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions fixed by PR #408 are still failing #441

Open
kvid opened this issue Jan 15, 2025 · 3 comments · Fixed by #442
Open

GitHub Actions fixed by PR #408 are still failing #441

kvid opened this issue Jan 15, 2025 · 3 comments · Fixed by #442

Comments

@kvid
Copy link
Collaborator

kvid commented Jan 15, 2025

The #408 update of GitHub Actions has been merged into master. I also tried cherry-picking this commit to #416, and the new actions were executed successfully, but two old outdated actions (build 3.7 and build 3.8) seem still to be executed also, and since those fail, it blocks merging. How can I disable old actions after updating old branches with these new actions? @martinrieder @amotl @tobiasfalk @formatc1702 or anyone else?

Could my problem be related to this? https://github.com/orgs/community/discussions/26256

Originally posted by @kvid in #408 (comment)

This accepted answer seems relevant: https://stackoverflow.com/questions/67743583/how-can-i-stop-github-actions-from-requiring-old-nodejs-builds

I find the old actions as required before merging into dev or master, and it seems I can remove them as required, but I don't find the new actions to replace them. What am I missing?

Update: I probably need to cherry-pick the squash commit from mege-in of this PR also into the target dev branch before correcting the branch protecting rules, but I must wait testing this until I have access to my PC again.

Originally posted by @kvid in #408 (comment)

This issue is currently blocking all PRs from passing required actions.

@kvid
Copy link
Collaborator Author

kvid commented Jan 15, 2025

By cherry-picking the commit described above also into the dev branch, I finally was able to make the branch protecting rules using the new actions, and it stopped failing due to not finding the old actions anymore.

However, the new actions also fail, like this: https://github.com/wireviz/WireViz/actions/runs/12736147371

"The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04." is reported by the failing action, and the remaining operations were canceled.

It seems the "ubuntu-latest" specifyer started to use ubuntu-24.04 instead of ubuntu-22.04 recently, and ubuntu-24.04 only support Python 3.9, 3.10, 3.11, and 3.12, but has stopped supporting Python 3.7 and 3.8 - and hence those actions are failing. For more details, see actions/runner-images#10636

If we still want actions that uses Python 3.7 and 3.8, then we must specify ubuntu-22.04 for those. Otherwise, we can just drop supporting Python 3.7 and 3.8 from future versions, but then we also need to update README and setup files.

@kvid kvid changed the title GitHub Actions fixed by #408 is still failing GitHub Actions fixed by PR #408 are still failing Jan 15, 2025
@kvid kvid mentioned this issue Jan 15, 2025
5 tasks
@amotl
Copy link
Member

amotl commented Jan 15, 2025

Yes, exactly. For supporting EOL versions of Python, you need to run it on ubuntu-22.04 or even ubuntu-20.04 when looking at Python 3.6 ;]. Let me know if you need any additional support on this topic, wrangling GitHub Action workflow recipes.

@formatc1702
Copy link
Collaborator

I would have no issue with dropping support for EOL versions, so even if there is a fix by using old Ubuntu distros, it's good to be able to shake off old baggage, and we don't have the resources to keep worrying too much about backward compatibility, especially if it means not being able to use new features.

So from my side, absolute green light to just drop support for old versions.

If the issue persists, it's also OK to temporarily change the settings and to not require passed checks for merge to be allowed, as long as the tests pass with current Python versions.

If this is something only I can do, and you need it, feel free to ping me; mail is also fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants