Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host the NodeJS icon? #442

Open
tabatkins opened this issue Apr 30, 2024 · 2 comments
Open

Host the NodeJS icon? #442

tabatkins opened this issue Apr 30, 2024 · 2 comments

Comments

@tabatkins
Copy link
Contributor

tabatkins commented Apr 30, 2024

The MDN annotations boxes used across Bikeshedded specs reference a bunch of UA icons, all but one of which are loaded from https://resources.whatwg.org/browser-logos. The NodeJS logo is instead loaded from nodejs.org (originally https://nodejs.org/static/images/favicons/favicon.ico), but at some point in the recent past they moved their icon location, so it's now a broken image.

Do we have an appetite for serving the NodeJS logo from resources.whatwg.org as well?

@tylerjmorg
Copy link
Contributor

Hey tabatkins,

It looks like WHATWG is loading the browser logos through npm and setting the target url to resources.whatwg.org/browser-logos

Idk if it's just me, but I'm having a hard time finding an MDN with the NodeJS icon, are you able to provide an example of where the NodeJS icon is supposed to be represented? I'll take a look and see about submitting a PR.

@tabatkins
Copy link
Contributor Author

The official icons are hosted at https://nodejs.org/en/about/branding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants