Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bikeshed errors #15

Closed
annevk opened this issue Nov 11, 2016 · 3 comments
Closed

Bikeshed errors #15

annevk opened this issue Nov 11, 2016 · 3 comments

Comments

@annevk
Copy link
Member

annevk commented Nov 11, 2016

WARNING: The following <var>s were only used once in the document:
  'samplerate'
  'doctype size'
If these are not typos, please add an ignore='' attribute to the <var>.
LINK ERROR: No 'dfn' refs found for 'whitespace character'.
LINK ERROR: No 'dfn' refs found for 'plugin context'.
LINK ERROR: No 'dfn' refs found for 'style context'.
LINK ERROR: No 'dfn' refs found for 'script context'.

@padenot I believe the first two have been introduced by you and it does look like those algorithms have some kind of mistake.

Not really sure how to resolve the remainder or what was intended there. @GPHemsley?

@GPHemsley
Copy link
Member

GPHemsley commented Jun 2, 2017

You can likely rewrite 'whitespace character' to use Infra. When I wrote this, there wasn't a centralized place where the differences between bytes/characters/code points were defined.

The context terms were extension points for what I took to be likely scenarios at the time. It's possible these have been superseded by Fetch or something else. See https://wiki.whatwg.org/wiki/Contexts for more info.

@annevk
Copy link
Member Author

annevk commented Nov 29, 2017

What's remaining here is algorithms using a variable only once. I have some vague plans to go through all algorithms and write tests for them, so hopefully they can be corrected then. However, I wouldn't mind someone else stepping in and doing that work as I don't know when I'll get to it.

@annevk
Copy link
Member Author

annevk commented Sep 14, 2018

#80 ends up fixing the warnings, but doesn't actually fix the algorithms here. The MP3 variable issue will be tracked by #70 going forward.

@annevk annevk closed this as completed in ce1750b Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants