Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken references in Compatibility Standard for window.orientation #223

Closed
1 task
dontcallmedom-bot opened this issue Nov 16, 2022 · 4 comments · Fixed by #241 or w3c/strudy#366
Closed
1 task
Assignees

Comments

@dontcallmedom-bot
Copy link

While crawling Compatibility Standard, the following links to other specifications were detected as pointing to non-existing anchors:

This issue was detected and reported semi-automatically by Strudy based on data collected in webref.

@miketaylr
Copy link
Member

https://compat.spec.whatwg.org/#dfn-window-orientation-angle

Looks like there's some recent updates in Screen Orientation, so we should update to match the new hotness.

@marcoscaceres
Copy link
Member

@miketaylr, should we just move the window.orientation stuff to the orientation spec?
w3c/screen-orientation#249

window.orientation is widely used (I think) so we probably can't get rid of it (and it's interoperable)... wdyt? What's been commonly done in these cases?

@karlcow
Copy link
Member

karlcow commented Apr 14, 2023

@marcoscaceres @miketaylr I moved this comment in a proper issue.
#239

@karlcow karlcow changed the title Broken references in Compatibility Standard Broken references in Compatibility Standard for window.orientation Apr 14, 2023
@miketaylr miketaylr self-assigned this Apr 20, 2023
@miketaylr
Copy link
Member

Let me fix this first, then we can work on #239.

miketaylr added a commit that referenced this issue Apr 20, 2023
The old algorithm we got the angle from ScreenOrientation no longer
exists, so instead we get the "current orientation angle". But this
is a no-op refactor - the result is the same.

Fixes #223
karlcow pushed a commit that referenced this issue Apr 22, 2023
The old algorithm we got the angle from ScreenOrientation no longer
exists, so instead we get the "current orientation angle". But this
is a no-op refactor - the result is the same.

Fixes #223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants