Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using credentials through optionalServiceBuilder fails #12

Open
guntars opened this issue Nov 5, 2016 · 1 comment
Open

Using credentials through optionalServiceBuilder fails #12

guntars opened this issue Nov 5, 2016 · 1 comment

Comments

@guntars
Copy link

guntars commented Nov 5, 2016

When using the provider with json credentials, it fails because GoogleCloudStorageAdaptor requires StorageClient as first param, but ServiceBuilder is given instead.

When adding the config to $adapterConfiguration like in case of project_id and leaving $optionalServiceBuilder as null, then it works just fine.

I think the references to optionalServiceBuilder can be entirely left out, because they don't seem to do anything.

@jcespinosa
Copy link

jcespinosa commented Aug 15, 2017

Maybe is a little bit late, but, is better to write your own service provider and use the Google Cloud Storage Adapter of the same author (https://github.com/cedricziel/flysystem-gcs).
The short way is to copy the contents of src/Websight/GcsProvider/CloudStorageServiceProvider, paste on your own service provider, tune it and add it to your application instead of Websight\GcsProvider\CloudStorageServiceProvider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants