-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assessments.michaelhyatt.com - site is not usable #25280
Comments
Thanks for the report, but I'm not able to reproduce the issue. Tested with: @birtles , could you please update to the latest Firefox version, and give it another try? |
Yes, it is working for me now. I tested in latest Nightly both when I filed this issue 17 days ago and now so it appears this has been fixed in Nightly in the last 17 days. Testing with Firefox 65 the error still reproduces. It would be good to find a fix range for this so we don't regress it. @softvision-sergiulogigan would you mind running mozregression on this to find the fix? |
I cannot reproduce the issue on Release either, @birtles I also ran MozRegression starting with 1st of January. I was unable to find a build where the animation fails. All the "bad" builds are actually the builds that were displaying the animation. |
Hmm, that's odd although it's not the animation that's the problem, it's the text not updating. On a clean profile on Firefox 65.0.1 on Windows 10 I can see the animation but the text below doesn't update. I've just re-tested now with a completely new profile and I can still reproduce. The release binary I have is a localized Japanese one and I am accessing from Japan but I don't think that should affect it. |
Even after setting English to my preferred language, I can still reproduce the problem. The only other setting I notice that is interesting is that, because I am testing on a touchscreen laptop, accessibility services appear to be enabled. |
to reproduce.
|
And there is this in their code // Only run the over effects if not touchscreen:
if ( !isTouchDevice ) {
$(".base-question li").mouseenter( handlerIn ).mouseleave( handlerOut );
}
function handlerIn() {
var idVal = $(this).find('input[type=radio]').attr("id");
var hoverDesc = $("label[for='"+idVal+"']").text();
var thisPage = $(this).closest(".gform_page");
$('.base-question-desc', thisPage).css("display", "none");
$(".base-question").append('<div class="base-question-desc-hover" style="text-align:center;">' + hoverDesc + '</div>');
}
function handlerOut() {
var thisPage = $(this).closest(".gform_page");
$('.base-question-desc-hover').remove();
$('.base-question-desc', thisPage).css("display", "block");
} |
so I think that's the reason, they don't think that laptop with touch screen exists. pushing to needscontact. |
and the test for the touch is done by
|
This might rely on a bug in Chrome. |
This is the opposite case though. On a Dell XPS 15 with Windows 10, |
Looks like Chrome deliberately disable this on desktop: https://bugs.chromium.org/p/chromium/issues/detail?id=392584#c22 |
There was some discussion here: https://lists.w3.org/Archives/Public/public-touchevents/2016Dec/0007.html I guess Firefox never followed the Chrome proposal there. /cc @smaug---- |
See additional context at w3c/touch-events#64 and https://bugzilla.mozilla.org/show_bug.cgi?id=1412485. To me, "'ontouchstart' in window" seems irreparably baked into the web to mean "is this a phone". I don't love any of the work-arounds we've had over the years TBH... |
Thanks Rick! That's very helpful. |
Like here in #25966 there are issues with touch/non touch on desktop. And in addition to window, this one reports isTouch: 'ontouchstart' in document.documentElement, |
Close as duplicate of #1412485 (Mozilla) |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue at https://webcompat.com/issues/new if you are experiencing a similar problem. |
URL: https://assessments.michaelhyatt.com/lifescore/assessment/
Browser / Version: Firefox 67.0
Operating System: Windows 10
Tested Another Browser: Yes
Problem type: Site is not usable
Description: Hovering over options does not update the text
Steps to Reproduce:
Expected results:
The text that says,
"Hover over each rating above. If the description that appears here aligns with your current reality, select that rating."
should be replaced with,
"I am generally happy and upbeat. I am confident and rarely worry. I manage stress in a healthy way. I give others the benefit of the doubt and am quick to forgive."
Actual results:
The text does not update.
Works as expected in Chrome.
Browser Configuration
Console Messages:
Reported by @birtles
From webcompat.com with ❤️
The text was updated successfully, but these errors were encountered: