Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification Review: FetchLater API #887

Closed
mingyc opened this issue Aug 28, 2023 · 6 comments
Closed

Specification Review: FetchLater API #887

mingyc opened this issue Aug 28, 2023 · 6 comments
Assignees
Labels
Progress: review complete Resolution: satisfied The TAG is satisfied with this design Topic: BFCache Topic: fetch and preload Things that live on top of (but close to) networking. Venue: WHATWG

Comments

@mingyc
Copy link

mingyc commented Aug 28, 2023

こんにちは TAG-さん!

I'm requesting a TAG review of Fetchlater API.

This is a proposal for FetchLater API. It is a system for sending beacons when pages are discarded, that uses a stateful API rather than having developers explicitly send beacons themselves.

Further details:

  • [✓] I have reviewed the TAG's Web Platform Design Principles
  • Relevant time constraints or deadlines: BY Q4 2023
  • The group where the work on this specification is currently being done: whatwg/fetch
  • The group where standardization of this work is intended to be done (if current group is a community group or other incubation venue):
  • Major unresolved issues with or opposition to this specification: The PR is not approved yet.
  • This work is being funded by: Google

You should also know that...

[please tell us anything you think is relevant to this review]

We'd prefer the TAG provide feedback as (please delete all but the desired option):

🐛 open issues in our GitHub repo for each point of feedback

☂️ open a single issue in our GitHub repo for the entire review

💬 leave review feedback as a comment in this issue and @-notify @mingyc, @fergald, @noamr

@torgo torgo added Topic: fetch and preload Things that live on top of (but close to) networking. and removed Progress: untriaged labels Aug 30, 2023
@torgo torgo added this to the 2023-09-04-week milestone Aug 30, 2023
@cynthia
Copy link
Member

cynthia commented Sep 7, 2023

Discussed during plenary this week. API seems fine, but the naming is a bit strange, "fetch later" could be misunderstood as a deferred fetch, when what you are getting is a guaranteed fetch when the document is gone. We don't have any better suggestions, but just wanted to point out the possibility of misunderstanding.

Explainer could use a bit more spelling out what the user story is. I have some speculations on how this could be used, but that's wildly speculative. Could you add some problems this proposal solves?

@mingyc
Copy link
Author

mingyc commented Sep 7, 2023

"fetch later" could be misunderstood as a deferred fetch

The current PR (whatwg/fetch#1647) actually calls the algorithm deferred fetching, I think it's intentional.

@noamr FYI

Explainer could use a bit more spelling out what the user story is. I have some speculations on how this could be used, but that's wildly speculative. Could you add some problems this proposal solves?

My bad that the linked explainer does not point to the entry explainer describing the overall goal. Please let me know if the problem description there is clear or not.

Also, I will try to include more story into the fetch later explainer.

@noamr
Copy link

noamr commented Sep 7, 2023

Discussed during plenary this week. API seems fine, but the naming is a bit strange, "fetch later" could be misunderstood as a deferred fetch, when what you are getting is a guaranteed fetch when the document is gone. We don't have any better suggestions, but just wanted to point out the possibility of misunderstanding.

I don't really understand this comment. The fetch is deferred to when the document is gone/deactivated. It's called now, and processed at a later time.

@cynthia
Copy link
Member

cynthia commented Sep 19, 2023

I don't really understand this comment. The fetch is deferred to when the document is gone/deactivated. It's called now, and processed at a later time.

To clarify the sentiment on the naming - it was about the ambiguity of "later" (which can be any time between now and whenever) when it's actually at the point of document destruct (which is much more narrow window than "between now and whenever").

@noamr
Copy link

noamr commented Sep 19, 2023

I don't really understand this comment. The fetch is deferred to when the document is gone/deactivated. It's called now, and processed at a later time.

To clarify the sentiment on the naming - it was about the ambiguity of "later" (which can be any time between now and whenever) when it's actually at the point of document destruct (which is much more narrow window than "between now and whenever").

It's actually "any time between now and document destruct or the given timeout, as late as possible". I think "later" conveys this.

@plinss plinss modified the milestones: 2023-09-04-week, 2023-09-25-week Sep 25, 2023
@torgo torgo modified the milestones: 2023-09-25-week, 2023-10-09-week Oct 8, 2023
@cynthia
Copy link
Member

cynthia commented Oct 10, 2023

It's actually "any time between now and document destruct or the given timeout, as late as possible". I think "later" conveys this.

Understood. Happy to move this forward in that case, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: review complete Resolution: satisfied The TAG is satisfied with this design Topic: BFCache Topic: fetch and preload Things that live on top of (but close to) networking. Venue: WHATWG
Projects
None yet
Development

No branches or pull requests

6 participants