Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Early Return Behavior for Fullscreen and Minimized States in BiDi Spec (SetClientWindowState) #839

Closed
Temidayo32 opened this issue Dec 23, 2024 · 5 comments
Labels
bug Something isn't working module-browser Browser module

Comments

@Temidayo32
Copy link
Contributor

Temidayo32 commented Dec 23, 2024

Description:

The current BiDi specification states the following in set the client window state:

  1. Let current state be get the client window state with window.
  2. If current state is equal to state, return success with data null.

This behavior prevents resizing or moving a window in the Normal state due to the early return.

A suggestion will be to allow early return only for Fullscreen and Minimized states when the requested state matches the current state. This adjustment ensures flexibility for Normal state operations while optimizing behavior for Fullscreen and Minimized states.

@whimboo whimboo added bug Something isn't working module-browser Browser module labels Dec 30, 2024
@whimboo
Copy link
Contributor

whimboo commented Dec 30, 2024

@Temidayo32 thank you for filing the issue. Would you be interested as well to provide a pull request for it? Therefore you will have to join the W3C group first.

@Temidayo32
Copy link
Contributor Author

@Temidayo32 thank you for filing the issue. Would you be interested as well to provide a pull request for it? Therefore you will have to join the W3C group first.

Yes, I will. I have created an account. Account awaiting further review/.

@whimboo
Copy link
Contributor

whimboo commented Jan 7, 2025

@Temidayo32 you can go ahead and create a PR with the fix without a membership. Just fixing a bug should not actually require to be a member.

@Temidayo32
Copy link
Contributor Author

Alright. Got it.

@whimboo
Copy link
Contributor

whimboo commented Jan 8, 2025

Fixed by #844. Thanks @Temidayo32!

@whimboo whimboo closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module-browser Browser module
Projects
None yet
Development

No branches or pull requests

2 participants