Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve json modules in typescript #2313

Closed
3 tasks done
filiplindqvist-netlight opened this issue Sep 23, 2020 · 6 comments
Closed
3 tasks done

Resolve json modules in typescript #2313

filiplindqvist-netlight opened this issue Sep 23, 2020 · 6 comments

Comments

@filiplindqvist-netlight
  • I have searched through existing issues
  • I have read through docs
  • I have read FAQ

Info

  • Platform: macOS
  • Vetur version: 0.28.0
  • VS Code version: 1.49.1

Problem

Vetur has problems detecting json modules in typescript.
image

Reproducible Case

Repo: https://github.com/filiplindqvist-netlight/vetur-bug-jsonmodule
Change: filiplindqvist-netlight/vetur-bug-jsonmodule@beb4888

@ci010
Copy link

ci010 commented Sep 24, 2020

I think the draft PR #1495 might resolve this, but it seems that PR has paused for a while.

@yoyo930021
Copy link
Member

I think the draft PR #1495 might resolve this, but it seems that PR has paused for a while.

No, It isn't.
because The related part is in #2095 and it is merged.

@yoyo930021
Copy link
Member

yoyo930021 commented Sep 24, 2020

If anyone can reproduce?
I can't reproduce.
I need more information.
截圖 2020-09-24 下午5 06 37

@filiplindqvist-netlight
Copy link
Author

@yoyo930021 What more information is relevant to provide?

@yoyo930021
Copy link
Member

yoyo930021 commented Sep 24, 2020

@yoyo930021 What more information is relevant to provide?

  1. Open vscode.
  2. Disable all other extensions.
  3. Enable Vetur.
  4. Open reproducible case folder.
  5. Is it achievable?

@filiplindqvist-netlight
Copy link
Author

Thanks for the coaching. I did the above steps, and now it seems to work, even with ALL extensions active again. 🧐
We can close this for now then. I'll try my private repos see if I can repo at all anymore. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants