Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation bug #53

Open
GabiDanciu opened this issue Jan 21, 2021 · 2 comments
Open

Translation bug #53

GabiDanciu opened this issue Jan 21, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@GabiDanciu
Copy link

I try to translate this section
image ,but I can't. It's about the loading reviews message when the product page is loading. The component is product-summary-rating. In messages folder I have only those possibilities: "store/reviews.list.summary.loading": "Loading summary…", and "store/reviews.list.loading": "Loading reviews…". I have tried to translate in romanian both... but no succes.

How I tried:

{
"args": {
"to": "ro-RO",
"messages": [
{
"srcLang": "en-DV",
"srcMessage": "store/reviews.list.summary.loading",
"targetMessage": "Incarca recenzii",
"context": "[email protected]"
}
]
}
}

@GabiDanciu GabiDanciu added the bug Something isn't working label Jan 21, 2021
@khrizzcristian
Copy link
Contributor

It's hardcoded here on line 208. https://github.com/vtex-apps/reviews-and-ratings/blob/master/react/RatingSummary.tsx

i'll fix this

@0100010089
Copy link

Any news about this @khrizzcristian ?
I can make a PR if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants