-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect coverage in web workers with @vitest/web-worker and @vitest/coverage-v8 #7379
Comments
The hard-coded execution wrapper doesn't match vitest/packages/coverage-v8/src/provider.ts Lines 31 to 32 in 1154662
Custom context is created at: vitest/packages/web-worker/src/runner.ts Lines 11 to 17 in 1154662
vitest/packages/web-worker/src/worker.ts Lines 50 to 97 in 1154662
We should probably pass the Changing the ![]() |
Describe the bug
I'm using
@vitest/web-worker
to test a web worker.@vitest/coverage-v8
reports incorrect coverage metrics, while@vitest/coverage-istanbul
seems to work fine.Reproduction
https://github.com/robojumper/vitest-web-worker-v8-coverage-bug - run
npm run test:coverage
and view the coverage report forsrc/worker/worker.ts
:v8:
![Image](https://private-user-images.githubusercontent.com/14299449/407754076-4bcc8246-12e3-4063-9fca-9a8a134e0951.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNTMwMjEsIm5iZiI6MTczOTA1MjcyMSwicGF0aCI6Ii8xNDI5OTQ0OS80MDc3NTQwNzYtNGJjYzgyNDYtMTJlMy00MDYzLTlmY2EtOWE4YTEzNGUwOTUxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDIyMTIwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU1YmQ1NGNhOTExMTJkODQwODY0YWZmNjY4ZjIwMzYwMGYzYWE3NGYwM2VlNDcxNTUzZTZiMmIxMjY3ZTkwYTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.D3WxOpUqoD6-cFPWio30t7LzEqukWsbfCeoTx7l8Buo)
istanbul:
![Image](https://private-user-images.githubusercontent.com/14299449/407754135-c2609e6e-6b61-4092-ad71-9636d1918a3f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNTMwMjEsIm5iZiI6MTczOTA1MjcyMSwicGF0aCI6Ii8xNDI5OTQ0OS80MDc3NTQxMzUtYzI2MDllNmUtNmI2MS00MDkyLWFkNzEtOTYzNmQxOTE4YTNmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDIyMTIwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdmNGNlNjE1YzU3ZTY5NTU4NjE1M2ZjNzg0MGVlNmE3NjIxZDNmMjM1MDhhYTM1YzgyODJhNzg2NGZjNDE0ZjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.iRUtRZPKDdx3hIA7oUb6ueZof_dtoaber-iyppXpjDw)
istanbul coverage looks correct while v8 coverage is completely wrong.
System Info
Used Package Manager
npm
Validations
The text was updated successfully, but these errors were encountered: