Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hardcode any fips codes #47

Open
sglyon opened this issue Jun 19, 2020 · 2 comments
Open

Don't hardcode any fips codes #47

sglyon opened this issue Jun 19, 2020 · 2 comments

Comments

@sglyon
Copy link
Member

sglyon commented Jun 19, 2020 •
edited
Loading

ref #46 and valorumdata/cmdc.py#19
@cc7768
Copy link
Contributor

cc7768 commented Jun 19, 2020 •
edited
Loading

Moving conversation from #46 here:

sglyon: @cc7768 I vote we avoid hard coding any fips codes.

Perhaps we could use the us package to get them for us?

@cc7768
Copy link
Contributor

cc7768 commented Jun 19, 2020

There are places that something has to be hard coded, right?

The us package has not added county support (last time I checked) -- It's been an open PR for awhile. Maybe we:

  1. Get state fips codes from the us package
  2. Hard code the county name rather than the fips code which is easier to verify and could be used to merge using our SQL database?

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sglyon @cc7768