Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ASAN/TSAN build #19

Open
allenss-amazon opened this issue Jan 22, 2025 · 1 comment
Open

Support ASAN/TSAN build #19

allenss-amazon opened this issue Jan 22, 2025 · 1 comment
Assignees

Comments

@allenss-amazon
Copy link
Member

Vitaly volunteered to do this one.

@yairgott yairgott reopened this Jan 23, 2025
@yairgott
Copy link
Collaborator

To support this in Bazel, you can implement ASAN/TSAN configurations. For examples, you can search on GitHub, such as this search.

Note that setting up the configuration is often straightforward, but ensuring all unittests pass may require additional effort. It’s recommended to adopt ASAN/TSAN incrementally: in the first phase, focus on a subset of unittests that pass, while disabling those that don’t work when ASAN/TSAN enabled.

The next step is to create a GitHub workflow to run the unittests with the ASAN/TSAN configuration on presubmit. This can be done by cloning and modifying the existing workflow unittests.yml file.

@yairgott yairgott reopened this Jan 23, 2025
@yairgott yairgott changed the title Update Build scripts to include ASAN/TSAN Support ASAN/TSAN build Jan 23, 2025
@yairgott yairgott modified the milestone: Version 1.0 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants