Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools.choose_cluster() function doesn't handle named clusters #246

Closed
mbukatov opened this issue Mar 22, 2019 · 2 comments
Closed

tools.choose_cluster() function doesn't handle named clusters #246

mbukatov opened this issue Mar 22, 2019 · 2 comments

Comments

@mbukatov
Copy link
Contributor

mbukatov commented Mar 22, 2019 •
edited
Loading

When a cluster was imported with a name, choose_cluster (from usmqe/web/tools.py) function doesn't recognize it and returns None.
@mbukatov
Copy link
Contributor Author

fyi: @ebondare

@mbukatov
Copy link
Contributor Author

mbukatov commented Mar 22, 2019 •
edited
Loading

This could be probably generalized, so that @fbalak could remove duplicated lines (shown bellow) in his tests:

    if cluster_reuse["short_name"]:
        cluster_identifier = cluster_reuse["short_name"]
    else:
        cluster_identifier = cluster_reuse["integration_id"]

So it's related to #229

@ebondare ebondare mentioned this issue Mar 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbukatov