From 3616db525f02f16d8c893047bcd5a0edbb8703a4 Mon Sep 17 00:00:00 2001 From: Sergej Samsonenko Date: Sun, 26 Dec 2021 23:05:07 +0100 Subject: [PATCH 1/2] refactor: favicon --- shopify/config/settings_schema.json | 6 +++--- shopify/layout/theme.liquid | 6 +++--- shopify/locales/en.default.schema.json | 7 +++++++ 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/shopify/config/settings_schema.json b/shopify/config/settings_schema.json index 33231722..5bdf5266 100644 --- a/shopify/config/settings_schema.json +++ b/shopify/config/settings_schema.json @@ -21,13 +21,13 @@ ] }, { - "name": "Favicon", + "name": "t:settings_schema.favicon.name", "settings": [ { "type": "image_picker", "id": "favicon", - "label": "Image", - "info": "32 x 32px .png recommended" + "label": "t:settings_schema.favicon.settings.label", + "info": "t:settings_schema.favicon.settings.info" } ] } diff --git a/shopify/layout/theme.liquid b/shopify/layout/theme.liquid index f5f6c025..96868b2e 100644 --- a/shopify/layout/theme.liquid +++ b/shopify/layout/theme.liquid @@ -9,10 +9,10 @@ - {%- if settings.favicon -%} + {% if settings.favicon %} - {%- endif -%} - + {% endif %} + {{ page_title | escape }} {% if page_description %} diff --git a/shopify/locales/en.default.schema.json b/shopify/locales/en.default.schema.json index 8166d7ec..6ca7c3ec 100644 --- a/shopify/locales/en.default.schema.json +++ b/shopify/locales/en.default.schema.json @@ -6,6 +6,13 @@ "header": "About JSON settings", "paragraph": "The settings_schema.json file controls the content of the Theme settings area of the theme editor. Settings in this file translate to global theme settings, which can be accessed through the Liquid settings object. [Learn more](https://shopify.dev/themes/architecture/settings)" } + }, + "favicon": { + "name": "Favicon", + "settings": { + "label": "Image", + "info": "32 x 32px .png recommended" + } } }, "sections": { From e7539e8055254143e9e0c32d926fac8659df03e1 Mon Sep 17 00:00:00 2001 From: Sergej Samsonenko Date: Sun, 26 Dec 2021 23:05:31 +0100 Subject: [PATCH 2/2] chore: version bump --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 36b7bb7f..11b6cc84 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "shopify-theme-lab", "description": "Customizable modular development environment for blazing-fast Shopify theme creation", "author": "Sergej Samsonenko", - "version": "4.4.0", + "version": "4.4.1", "license": "MIT", "scripts": { "start": "run-p -sr shopify:serve webpack:watch",