New candidate revision (r57) create icons issue #257
Comments
|
In r48 in r57 libpixbufloader-svg.so change to libpixbufloader_svg.so for some reason? |
|
I'll check it. |
|
Mmm... odd... I'll try to rename that file. |
|
Ok, it seems that snaps that use gnome extension do rebuild the gdk-pixbuf-loaders.cache at install or update. The problem is that, when the gnome-XX-XXXX.snap is updated, that cache isn't rebuilt, so any change would break that. Renaming the loader in the sdk and in the contents snap does work, but the best solution would be to rebuild all those caches (not only the loaders, but also the icons and others) not only when a snap is updated, but also when the extensions on which it depends are updated. |
|
Is that rebuild logic part of the gnome wrapper? |
|
Maybe the best course of action is to check if |
|
Yes, it is. IIRC, it is part of the snapcraft-desktop-integration scripts. |
|
The |
|
So I think we need to update the wrapper logic first. I would suggest we revert the gnome-sdk change at least until the wrapper change is landed and published to stable |
|
Here it uses a md5sum to detect changes in the gtk-common-themes snap. Maybe we could do something like that for gnome? https://github.com/canonical/snapcraft-desktop-integration/blob/80aefcc8acafa2656e666ffa5e905fd91e2999e3/common/init#L46 |
|
The point is that I didn't change anything that whould produce that. It seems something in gdk-pixbuf-loaders, or maybe librsvg... |
This is required because version 2.59.1 changes the name of the gdk-pixbuf-loader from libpixbufloader-svg.so to libpixbufloader_svg.so, which breaks snaps because each snap stores its own loaders.cache file with the path for each loader, so an already installed snap will have a loaders.cache file with a svg loader path pointing to the former name, but the current file would be the later, thus it won't be able to load any svg. The right solution is to modify snapcraft-desktop-integration scripts to add a check that rebuilds any cache (not only pixbuf loaders, but also fonts, icons...) not only if the snap itself is updated, but also if any of the extensions is updated too. Fix ubuntu#257
Testing r57 with the evince candidate the icons in the decoration are missing, see screenshot
Also trying gnome-calculator from candidate
The text was updated successfully, but these errors were encountered: