Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider migrating from cargo raze to crate_universe #374

Closed
alexjpwalker opened this issue Oct 10, 2022 · 0 comments · Fixed by #408
Closed

Consider migrating from cargo raze to crate_universe #374

alexjpwalker opened this issue Oct 10, 2022 · 0 comments · Fixed by #408
Assignees
@alexjpwalker
Labels
priority: high status: solved type: refactor
Milestone
TypeDB Client: Ru...

Comments

@alexjpwalker
Copy link
Member

alexjpwalker commented Oct 10, 2022 •
edited
Loading

cargo raze used to provide more functionality than rules_rust's own crate_universe, so we adopted it. My understanding is that crate_universe has seen substantial development since that initial decision, and we should now revisit it.

At the time of writing, we have the following open issues related to cargo raze itself, or our usage of it:
@alexjpwalker alexjpwalker added this to the TypeDB: Rust Rewrite milestone Oct 10, 2022
@alexjpwalker alexjpwalker self-assigned this Oct 10, 2022
@dmitrii-ubskii dmitrii-ubskii mentioned this issue Jan 13, 2023
Merged
dmitrii-ubskii added a commit that referenced this issue Jan 16, 2023
@dmitrii-ubskii
Migrate to crate-universe (#408)
31ecccf 
## What is the goal of this PR?

We upgrade rules_rust to v.0.16.1 and migrate from using cargo-raze to
rules_rust's crate_universe for the purposes of translating cargo
dependencies to bazel dependencies.

## What are the changes implemented in this PR?

Closes #374.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexjpwalker alexjpwalker

Labels
priority: high status: solved type: refactor
Projects
None yet
Milestone
TypeDB Client: Rust Rewrite
Development

Successfully merging a pull request may close this issue.

Migrate to crate-universe dmitrii-ubskii/vaticle-dependencies
2 participants
@alexjpwalker @typedb-bot