Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctx deadline does not affect local request timeouts #90

Open
psalin opened this issue Sep 14, 2022 · 0 comments
Open

ctx deadline does not affect local request timeouts #90

psalin opened this issue Sep 14, 2022 · 0 comments

Comments

@psalin
Copy link
Collaborator

psalin commented Sep 14, 2022

For the client, the deadline set in the ctx only affects the grpc-timeout header sent to the server. It does not affect how requests time out on the client-side. Currently if the deadline is larger than the hard-coded 5s timeout, the request will timeout too soon. Also if the deadline is shorter than 5s, but the server does not reply according to the deadline, it will take 5s for the request to time out.

I think it would make sense for the deadline to affect the local timeouts as well, and not only the grpc-timeout header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant