From c7924e8f57fcba2d93cb70bf8dffd4f596a88bc7 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Wed, 5 Feb 2025 13:55:57 -0800 Subject: [PATCH] [AMD] Avoid unneeded instruction schedule pass runs (#5832) We only want to run them if an active variant is requested. --- third_party/amd/backend/compiler.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/third_party/amd/backend/compiler.py b/third_party/amd/backend/compiler.py index c54b31b847e1..f3f01c443d0d 100644 --- a/third_party/amd/backend/compiler.py +++ b/third_party/amd/backend/compiler.py @@ -218,7 +218,8 @@ def make_ttgir(mod, metadata, options): "equivalent behavior in the past.") amd.passes.ttgpuir.add_stream_pipeline(pm, options.num_stages, stream_prefetch) passes.common.add_canonicalizer(pm) - amd.passes.ttgpuir.insert_instruction_sched_hints(pm) + if options.instruction_sched_variant.lower() != "none": + amd.passes.ttgpuir.insert_instruction_sched_hints(pm) passes.ttgpuir.add_optimize_dot_operands(pm, True) passes.ttgpuir.add_remove_layout_conversions(pm) passes.ttgpuir.add_reduce_data_duplication(pm) @@ -274,8 +275,9 @@ def make_llir(src, metadata, options): passes.common.add_canonicalizer(pm) passes.common.add_cse(pm) passes.common.add_symbol_dce(pm) - amd.passes.ttgpuir.lower_instruction_sched_hints(pm, options.arch, options.num_stages, - options.instruction_sched_variant) + if options.instruction_sched_variant.lower() != "none": + amd.passes.ttgpuir.lower_instruction_sched_hints(pm, options.arch, options.num_stages, + options.instruction_sched_variant) if os.environ.get("TRITON_DISABLE_LINE_INFO", "0") == "0": passes.llvmir.add_di_scope(pm) amd.passes.ttgpuir.add_builtin_func_to_llvmir(pm, __HIP_FTZ)