Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Deadline should be configurable #131

Open
lorransr opened this issue Dec 17, 2024 · 3 comments
Open

Context Deadline should be configurable #131

lorransr opened this issue Dec 17, 2024 · 3 comments

Comments

@lorransr
Copy link

I created this issue on usql. I found that for long queries the context deadline is kind of short and I believe it should be configurable. Is it possible? and does it makes sense?

@nineinchnick
Copy link
Member

I don't think we need to have such a conservative defautl value for the query timeout, and it definitely should be configurable in the URL. It would also be good to make it consistent with the JDBC driver, which is a reference implementation.

@KasonBraley
Copy link

I have encountered this recently as well, and was quite surprised by this default. Would you be open to removing this default query timeout entirely and pushing that responsibility onto the user of the package? If a user would want to set a timeout or deadline on the query, they could just set that accordingly on the context that they pass in.

@nineinchnick
Copy link
Member

We should already handle a timeout set in a context. The default timeout can be increased by changing the trino.DefaultQueryTimeout variable, but it's global, cannot be changed through the URL, and generally it's a poor design choice. I'd suggest increasing it significantly, and deprecate it first, just in case anyone is relying on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants