Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation - add info about dependency pwa-kit-runtime #604

Closed
1 task done
surfmuggle opened this issue Feb 1, 2025 · 2 comments
Closed
1 task done
Assignees
Labels
enhancement New feature or request

Comments

@surfmuggle
Copy link

Summary

I followed the steps from the readme

  1. Run git clone https://github.com/trailheadapps/lwc-recipes-oss
  2. change into new directory cd lwc-recipes-oss
  3. Run npm install
  4. then npm run build
  5. and then npm run dev

I got some errors and this hint [config] peer dependency pwa-kit-runtime was not provided.

Running npm install pwa-kit-runtime reported

added 47 packages, changed 4 packages

17 vulnerabilities (11 high, 6 critical)

I assume some vulnerabilities will be fixed by 603.

Thanks

> npm install pwa-kit-runtime
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '[email protected]',
npm warn EBADENGINE   required: { node: '18.x' },
npm warn EBADENGINE   current: { node: 'v20.11.1', npm: '10.7.0' }
npm warn EBADENGINE }
npm warn deprecated [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.

added 47 packages, changed 4 packages, and audited 1590 packages in 32s

258 packages are looking for funding
  run `npm fund` for details

17 vulnerabilities (11 high, 6 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

Suggested Solution

Add info about needed packages
Upgrade dependencies

Alternative Solutions

do nothing

Code of Conduct

  • I agree to follow this project's Code of Conduct
@surfmuggle surfmuggle added the enhancement New feature or request label Feb 1, 2025
Copy link

github-actions bot commented Feb 1, 2025

Thank you for posting this issue. 🙇🏼‍♂️
We will come back to you shortly.

@pozil
Copy link
Contributor

pozil commented Feb 4, 2025

I rebuilt the project from scratch since the node@20 upgrade and this shouldn't be required anymore. Feel free to reopen the issue if needed.

@pozil pozil closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants