Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for seo/site defaults to be on a different page instead of site #50

Open
garethworld opened this issue Nov 15, 2023 · 3 comments
Open
Labels
accepting prs 🧜‍♀️ Not to be implemented in the future; except if feature is provided in a PR type: enhancement ✨ Suggests an enhancement; improves the plugin
Milestone

Comments

@garethworld
Copy link

I would like to put the defaults that are in my site.yml, on a different blueprint - is this possible?

@tobimori
Copy link
Owner

Right now, not. 😄
I might add this as an enhancement in a future version, given your "settings" approach makes much more sense with v4.0 now.

@tobimori tobimori added the type: enhancement ✨ Suggests an enhancement; improves the plugin label Nov 15, 2023
@tobimori tobimori changed the title Is it possible to change the location of seo/site fields ? Allow for seo/site defaults to be on a different page instead of site Nov 15, 2023
@tobimori tobimori added this to the 1.x milestone Nov 15, 2023
@tobimori tobimori added the accepting prs 🧜‍♀️ Not to be implemented in the future; except if feature is provided in a PR label Nov 15, 2023
@tobimori
Copy link
Owner

I'd accept a PR. Make it a config setting that can hold a closure (to resolve a page with UUIDs), or simply a string (site or page slug).

Has to be resolved here.

@tobimori
Copy link
Owner

there might also be some blueprint changes necessary, like here: https://github.com/tobimori/kirby-seo/blob/main/blueprints/site.yml#L38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs 🧜‍♀️ Not to be implemented in the future; except if feature is provided in a PR type: enhancement ✨ Suggests an enhancement; improves the plugin
Projects
None yet
Development

No branches or pull requests

2 participants