Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error not surfaced properly (HTML Diff might have changed its invocation contract) #156

Closed
annevk opened this issue Dec 3, 2024 · 3 comments · Fixed by #157
Closed

Error not surfaced properly (HTML Diff might have changed its invocation contract) #156

annevk opened this issue Dec 3, 2024 · 3 comments · Fixed by #157

Comments

@annevk
Copy link
Contributor

annevk commented Dec 3, 2024 •
edited
Loading

See whatwg/url#846.

It seems HTML Diff changed its invocation contract? "Error: options.uri is a required argument"
@annevk
Copy link
Contributor Author

annevk commented Dec 3, 2024

cc @dontcallmedom

tobie added a commit that referenced this issue Dec 3, 2024
@tobie
Fix bug introduced in #155
bd5207e 
Closes #156
@tobie tobie mentioned this issue Dec 3, 2024
Merged
@tobie
Copy link
Owner

tobie commented Dec 3, 2024

Sorry, I just introduced this bug minutes ago while fixing something else.

@tobie tobie closed this as completed in #157 Dec 3, 2024
@tobie tobie closed this as completed in 4e7fe76 Dec 3, 2024
@annevk
Copy link
Contributor Author

annevk commented Dec 3, 2024

Thanks @tobie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug introduced in #155 tobie/pr-preview
2 participants
@tobie @annevk