Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidance for migration from AuthorizationRoot #109

Open
daltskin opened this issue Oct 17, 2017 · 3 comments
Open

Guidance for migration from AuthorizationRoot #109

daltskin opened this issue Oct 17, 2017 · 3 comments

Comments

@daltskin
Copy link
Contributor

Now that the project has been migrated to .NET Standard 2, is there any guidance on how to migrate code that was using AuthorizationRoot?

@niemyjski
Copy link
Collaborator

I haven't really thought on it too much, but it would be nice to have something based on the new configuration model that Microsoft provides. Would be really nice to have a pr for this. The old configuration model just was a serious PITA to port and would of made this library windows only even through it was .net standard 2.0. If we can make a typed model IAuthSettings or something like that we could inject them in via DI or even new up the new instances and inject those OAuth client instances into our app without leaking settings everywhere.

I've been doing the runtime config (removed the runtime keyword from the config model) . This is how I've been using this library for a really long time https://github.com/exceptionless/Exceptionless/blob/2d4b303250bb7826d6e867c7746d3f0f31e5c5aa/src/Exceptionless.Api/Controllers/AuthController.cs#L269

@niemyjski
Copy link
Collaborator

This is something we'll need to address before 1.0 If you have any feedback or ideas please let us know. I know it's not ideal but this change had to happen at some point as the old configuration is dead and we are not to a 1.0 yet.

@daltskin
Copy link
Contributor Author

The typed model idea sounds good, as long as there is an example of how to implement it. The old MVC sample app really helped understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants