From 8577c0b16cb6fea4777296790ef26e52bce53f04 Mon Sep 17 00:00:00 2001 From: Hamed Asghari Date: Tue, 29 Oct 2024 10:17:36 -0500 Subject: [PATCH 1/2] ci: Add Rails 8 to testing matrix --- .github/workflows/tests.yml | 4 ++++ Appraisals | 5 +++++ gemfiles/rails_8.0.gemfile | 20 ++++++++++++++++++++ 3 files changed, 29 insertions(+) create mode 100644 gemfiles/rails_8.0.gemfile diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index b3c3e257..d7bf04be 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -19,10 +19,14 @@ jobs: - "7.0" - "7.1" - "7.2" + - "8.0" ruby: - "3.1.6" - "3.2.5" - "3.3.5" + exclude: + - ruby: "3.1.6" + gemfile: "8.0" env: BUNDLE_GEMFILE: gemfiles/rails_${{ matrix.gemfile }}.gemfile diff --git a/Appraisals b/Appraisals index c160559c..958f1037 100644 --- a/Appraisals +++ b/Appraisals @@ -14,3 +14,8 @@ end appraise "rails_7.2" do gem "railties", "~> 7.2.0" end + +appraise "rails_8.0" do + gem "railties", "~> 8.0.0" + gem 'sqlite3', '>= 2.1' +end diff --git a/gemfiles/rails_8.0.gemfile b/gemfiles/rails_8.0.gemfile new file mode 100644 index 00000000..5d6a79dc --- /dev/null +++ b/gemfiles/rails_8.0.gemfile @@ -0,0 +1,20 @@ +# This file was generated by Appraisal + +source "https://rubygems.org" + +gem "addressable" +gem "ammeter" +gem "appraisal" +gem "capybara" +gem "database_cleaner" +gem "erb_lint", require: false +gem "factory_bot_rails" +gem "nokogiri" +gem "pry", require: false +gem "rails-controller-testing" +gem "rspec-rails" +gem "shoulda-matchers" +gem "sqlite3", ">= 2.1" +gem "railties", "~> 8.0.0" + +gemspec path: "../" From 024ba4800a1588ee2a598c1220fe703ab083c34d Mon Sep 17 00:00:00 2001 From: Hamed Asghari Date: Tue, 29 Oct 2024 10:18:02 -0500 Subject: [PATCH 2/2] chore: Fix erb_lint deprecation warnings --- .erb-lint.yml => .erb_lint.yml | 0 Rakefile | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename .erb-lint.yml => .erb_lint.yml (100%) diff --git a/.erb-lint.yml b/.erb_lint.yml similarity index 100% rename from .erb-lint.yml rename to .erb_lint.yml diff --git a/Rakefile b/Rakefile index 1055b16a..2891069a 100644 --- a/Rakefile +++ b/Rakefile @@ -21,7 +21,7 @@ end desc "Lint ERB templates" task :erb_lint do - sh("bundle", "exec", "erblint", "app/views/**/*.erb") + sh("bundle", "exec", "erb_lint", "app/views/**/*.erb") end desc "Run the specs and acceptance tests"