Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url parameter support #45

Open
kimberlyh66 opened this issue Aug 19, 2019 · 5 comments
Open

Add url parameter support #45

kimberlyh66 opened this issue Aug 19, 2019 · 5 comments

Comments

@kimberlyh66
Copy link
Contributor

kimberlyh66 commented Aug 19, 2019

Allow users to search for a specific map, plot, and management timeline by supplying url parameters (experiment name, sub experiment name, trait name, cultivar, and date).

@dlebauer
Copy link
Member

please separate into different files

@kimberlyh66
Copy link
Contributor Author

Output render functions have been removed from app.R and placed into separate files (either render-home-outputs.R or render-search-outputs.R depending on if render function is for home or search page) to improve organization of code.

@Chris-Schnaufer
Copy link

Waiting on review of Pull Request

@dlebauer
Copy link
Member

Probably needs to be refactored; could take the opportunity to implement a shiny package using the golem framework https://github.com/ThinkR-open/golem

@Chris-Schnaufer
Copy link

Needs discussion and investigation:
Investigate Golem for packaging the changes made; new functionality were added. It's not clear that the current approach is best.
Perhaps Kristina and Emily collaborate on reviewing this. Create a ticket to look into creating issues for bugs?
David: Kristina spend a day trying this out and documenting found problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants