Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolchain: panic if go.toolchain.rev doesn't match toolchain #13527

Closed
bradfitz opened this issue Sep 20, 2024 · 0 comments · Fixed by #13702
Closed

toolchain: panic if go.toolchain.rev doesn't match toolchain #13527

bradfitz opened this issue Sep 20, 2024 · 0 comments · Fixed by #13702

Comments

@bradfitz
Copy link
Member

We had some problems with the Android build lately using the wrong cached Go toolchain.

Let's panic at startup if we detect the wrong Go toolchain in use that doesn't match go.toolchain.rev (and we know that the intent is to use the Tailscale toolchain)

First bit was tailscale/go#104

/cc @raggi
bradfitz added a commit that referenced this issue Sep 20, 2024
@bradfitz
go.toolchain.rev: bump oss, test toolchain matches go.toolchain.rev
a897504 
Update go.toolchain.rev for tailscale/go#104 and
add a test that, when using the tailscale_go build tag, we use the
right Go toolchain.

We'll crank up the strictness in later commits.

Updates #13527

Change-Id: Ifb09a844858be2beb144a420e4e9dbdc5c03ae3a
Signed-off-by: Brad Fitzpatrick <[email protected]>
@bradfitz bradfitz mentioned this issue Sep 20, 2024
Merged
bradfitz added a commit that referenced this issue Sep 20, 2024
@bradfitz
go.toolchain.rev: bump oss, test toolchain matches go.toolchain.rev
3e9ca6c 
Update go.toolchain.rev for tailscale/go#104 and
add a test that, when using the tailscale_go build tag, we use the
right Go toolchain.

We'll crank up the strictness in later commits.

Updates #13527

Change-Id: Ifb09a844858be2beb144a420e4e9dbdc5c03ae3a
Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz added a commit to tailscale/tailscale-android that referenced this issue Sep 20, 2024
@bradfitz
Makefile: use "tailscale_go" build tag when using Tailscale's Go tool…
98eb426 
…chain

Updates tailscale/tailscale#13527
@bradfitz bradfitz mentioned this issue Sep 20, 2024
Merged
bradfitz added a commit to tailscale/tailscale-android that referenced this issue Sep 20, 2024
@bradfitz
Makefile: use "tailscale_go" build tag when using Tailscale's Go tool…
4b4cef3 
…chain

Updates tailscale/tailscale#13527

Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz added a commit to tailscale/tailscale-android that referenced this issue Sep 20, 2024
@bradfitz
Makefile: use "tailscale_go" build tag when using Tailscale's Go tool…
f26a828 
…chain

Updates tailscale/tailscale#13527

Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz added a commit that referenced this issue Oct 6, 2024
@bradfitz
tailscaleroot: panic if tailscale_go build tag but Go toolchain mismatch
23f41ae 
Fixes #13527

Change-Id: I05921969a84a303b60d1b3b9227aff9865662831
@bradfitz bradfitz mentioned this issue Oct 6, 2024
Merged
bradfitz added a commit that referenced this issue Oct 6, 2024
@bradfitz
tailscaleroot: panic if tailscale_go build tag but Go toolchain mismatch
dcab45e 
Fixes #13527

Change-Id: I05921969a84a303b60d1b3b9227aff9865662831
Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz added a commit that referenced this issue Oct 6, 2024
@bradfitz
tailscaleroot: panic if tailscale_go build tag but Go toolchain mismatch
1005cbc 
Fixes #13527

Change-Id: I05921969a84a303b60d1b3b9227aff9865662831
Signed-off-by: Brad Fitzpatrick <[email protected]>
kradalby pushed a commit that referenced this issue Oct 8, 2024
@bradfitz @kradalby
tailscaleroot: panic if tailscale_go build tag but Go toolchain mismatch
799d2b4 
Fixes #13527

Change-Id: I05921969a84a303b60d1b3b9227aff9865662831
Signed-off-by: Brad Fitzpatrick <[email protected]>
@a-jackson a-jackson mentioned this issue Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tailscaleroot: panic if tailscale_go build tag but Go toolchain mismatch tailscale/tailscale
1 participant
@bradfitz