-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update color scheme to meet WCAG #25
Comments
Oh yeah, those colors look good to me. |
Cool! Have done a first stab in #26, but getting some unexpected results when testing it out. What would a better way (than manually) to convert Prism-compatible syntax styles to Pygments? |
Ah, I've got a code snippet squirreled away in Bikeshed for that:
|
I saw this, but I wasn't sure where/how to run it? (I am not super familiar with Python) How do I prepare this file to run it (eg where do I put the Prism styles and how can I map from Prism token names to Pygments token names) and where do I run it? Thanks! |
Ah, so if you have pygments installed you can just run this from an independent script. But I already know how to do that, so if you could swap in the colors I'll do the rest. |
Ok this is ready to go in #26 ! I have updated the colors that are inside the comments, and the ones outside of it, but if you're generating them we can throw my changes outside of the comment? |
It appears the current color scheme in the highlighter doesn't meet WCAG color contrast requirements. I'd like to contribute updates to the colors.
In whatwg/whatwg.org#392, I worked on color contrast issues in WHATWG, and syntax highlights are one of the issues we haven't yet tackled there.
I don't have strong preferences around color schemes, my suggestion would be to use a11y-syntax-highlighting as that meets WCAG.
The text was updated successfully, but these errors were encountered: