Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Tool table not found during Import Machine Settings #429

Open
isukces opened this issue Dec 19, 2024 · 5 comments
Open

Error Tool table not found during Import Machine Settings #429

isukces opened this issue Dec 19, 2024 · 5 comments
Labels

Comments

@isukces
Copy link

isukces commented Dec 19, 2024

Issue: Error Tool table not found during Import Machine Settings

Problem Description

The Import Machine Settings feature causes the error Tool table not found. This issue occurs because the path to the tool file is incorrectly processed. The path is concatenated with Datapath.Tools using a backslash (\). However, the .ini file already contains the full path, so concatenating results in an invalid file name.

Steps to Reproduce

  1. Attempt to import machine settings using the Import Machine Settings feature.
  2. Observe the error: Tool table not found.

Cause

The path to the tool file is constructed incorrectly as:

Datapath.Tools + "\\" + tmpstr

Solution

Modify the code in the IniFile.cs file to use Path.Combine instead of manual string concatenation.

Correct Code:

Path.Combine(Datapath.Tools, tmpstr)

Additional Notes

Using Path.Combine ensures proper handling of paths regardless of the platform and avoids issues caused by incorrect concatenation.

@isukces isukces added the bug label Dec 19, 2024
@svenhb
Copy link
Owner

svenhb commented Dec 19, 2024

Thanks, I will test

@buddasticks
Copy link

i also have the exact same issue trying yo load use case

@svenhb svenhb closed this as completed in 7879b17 Jan 17, 2025
@svenhb
Copy link
Owner

svenhb commented Jan 17, 2025

I made changes, but forgot to make a new release. Can you check this version?
https://github.com/svenhb/GRBL-Plotter/blob/master/GRBL-Plotter_Setup_1751a.exe

@svenhb svenhb reopened this Jan 17, 2025
@buddasticks
Copy link

Will test when home .. my work around was just to remove the called for tools.csv from the saved caseuse.ini

@buddasticks
Copy link

It appears to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants