Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loudly error for invalid :global placement #14906

Open
dummdidumm opened this issue Jan 6, 2025 · 0 comments
Open

Loudly error for invalid :global placement #14906

dummdidumm opened this issue Jan 6, 2025 · 0 comments
Labels
css Stuff related to Svelte's built-in CSS handling

Comments

@dummdidumm
Copy link
Member

Describe the bug

In https://discord.com/channels/457912077277855764/1325334674784129035 someone was confused by a certain syntax failing with a "unclosed comment" error. Turns out it's us no erroring on a wrong :global placement, which leads to subsequent wrong "comment this out" logic.

The solution is to throw a validation error here.

Reproduction

playground link

Logs

No response

System Info

irrelevant

Severity

annoyance
@dummdidumm dummdidumm added the css Stuff related to Svelte's built-in CSS handling label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css Stuff related to Svelte's built-in CSS handling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dummdidumm