No database dumps found in backup SMS/2023-10-24-13-02-50.zip.

[MakaraDevOP]

hello, I have a problem with restoring the backup database
i using command: php artisan backup:restore --backup=latest

error appear like this , can you help ?

[stefanzweifel]

Well, I think the exception is quite clear: Your backup seems to not contain a database dump that can be imported.

To be more exact, there doesn't seem to be a db-dumps-directory. Here's a direct link to the code that throws that exception: link.

Could you check how the decompressed backup looks like? You should be able to find the downloaded backup in storage/app/backup-restore-temp.

storage/backup-temp

[stefanzweifel]

@MakaraDevOP Yeah, the package currently doesn't use database.connections.{connection}.dump.dump_binary_path. Will create a fix in the upcoming days.

[MakaraDevOP]

@stefanzweifel i'm waiting for you, thanks

[stefanzweifel]

I've started working on a fix in #40.
Would be great if you could give this a try by updating your project @MakaraDevOP.

Update composer.json

- "wnx/laravel-backup-restore": "^1.0",
+ "wnx/laravel-backup-restore": "dev-feat/use-dump_binary_path",

Install new version

composer upgrade wnx/laravel-backup-restore

Then run php artisan backup:restore as ususal.
As mentioned several times, I don't own a Windows device and running our test suite on GitHub Actions on Windows is quite tricky (#41). So errors can still happen.

Feel free to mention them here or better, create an issue.

[MakaraDevOP]

"wnx/laravel-backup-restore": "dev-feat/use-dump_binary_path",

This version supports MySQL CLI, but for my project, I need to change the path of PathToLocalDecompressedBackup to a public folder, and it's working 🎉🎉,Issue Fixed

From this :

public function getAbsolutePathToLocalDecompressedBackup(): string
{
    $filename = $this->restoreId;

    return storage_path('app'.DIRECTORY_SEPARATOR.'backup-restore-temp'.DIRECTORY_SEPARATOR.$filename);
}

Changed to: 👍🏼

public function getAbsolutePathToLocalDecompressedBackup(): string
{
    $filename = $this->restoreId;

    return storage_path('app\public'.DIRECTORY_SEPARATOR.'backup-restore-temp'.DIRECTORY_SEPARATOR.$filename);
}

[stefanzweifel]

Great to here it's working for you @MakaraDevOP!

Could you maybe explain or share an error message on why you needed to change the path to include the public folder?

Your local fix is not something I'm willing to make in the package. Storing the decompressed backup in storage/app/public would make the backup publicly available. That's a security issue if someone runs the command on a production server.

[stefanzweifel]

#40 has been merged and released in v1.1.3.
The path to the local decompressed backup remains in a not public-folder. So you might have to edit your vendor files again, if you update the package.

[MakaraDevOP]

I changed to a public folder because It couldn't find a file in storage/app, and then I changed to a public folder, and it was working well.

this function return false:

public function hasNoDbDumpsDirectory(): bool
{
    return ! Storage::disk($this->restoreDisk)
        ->has($this->getPathToLocalDecompressedBackup().DIRECTORY_SEPARATOR.'db-dumps');
}

Do you have any recommend to me ?

Thanks and respect 🙏

[stefanzweifel]

Sorry for the late reply here @MakaraDevOP.

I'm not sure how I can help you here.
From your comments, I don't understand why the default location in storage/app is not working in your project.

Maybe the package is downloading it in the wrong location? Maybe this is also related to the fact the I couldn't test the package on a Windows machine yet.